Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 651073002: Revert of [Easy Unlock] Port the BluetoothConnectionFinder class to native code. (Closed)

Created:
6 years, 2 months ago by yoichio
Modified:
6 years, 2 months ago
Reviewers:
Tim Song, Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Easy Unlock] Port the BluetoothConnectionFinder class to native code. (patchset #4 id:320001 of https://codereview.chromium.org/633253002/) Reason for revert: Causes compile failure on mac: http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder%20%28dbg%29/builds/75518 Original issue's description: > [Easy Unlock] Port the BluetoothConnectionFinder class to native code. > > A couple of pieces are left as TODOs for future CLs: > * Porting the "seek device by Bluetooth address" feature. > * Wiring up a screen lock state accessor. > > BUG=420946 > TEST=components_unittests > R=tengs@chromium.org > > Committed: https://crrev.com/ac4df1c4df6fdc7c771eb0bdeb15dbd6f2dbb98c > Cr-Commit-Position: refs/heads/master@{#299415} TBR=tengs@chromium.org,isherman@chromium.org NOTREECHECKS=true NOTRY=true BUG=420946 Committed: https://crrev.com/ab9f183ccbec50c1bfa42514019e089fccd9f0f4 Cr-Commit-Position: refs/heads/master@{#299420}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -582 lines) Patch
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/proximity_auth.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M components/proximity_auth/BUILD.gn View 3 chunks +7 lines, -6 lines 0 comments Download
M components/proximity_auth/bluetooth_connection.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D components/proximity_auth/bluetooth_connection_finder.h View 1 chunk +0 lines, -108 lines 0 comments Download
D components/proximity_auth/bluetooth_connection_finder.cc View 1 chunk +0 lines, -145 lines 0 comments Download
D components/proximity_auth/bluetooth_connection_finder_unittest.cc View 1 chunk +0 lines, -277 lines 0 comments Download
D components/proximity_auth/connection_finder.h View 1 chunk +0 lines, -37 lines 0 comments Download
M components/proximity_auth/connection_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yoichio
Created Revert of [Easy Unlock] Port the BluetoothConnectionFinder class to native code.
6 years, 2 months ago (2014-10-14 03:37:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651073002/1
6 years, 2 months ago (2014-10-14 03:38:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 03:38:44 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ab9f183ccbec50c1bfa42514019e089fccd9f0f4 Cr-Commit-Position: refs/heads/master@{#299420}
6 years, 2 months ago (2014-10-14 03:39:36 UTC) #4
Ilya Sherman
6 years, 2 months ago (2014-10-14 23:15:20 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/656963002/ by isherman@chromium.org.

The reason for reverting is: I believe that the original revert was incorrect,
so relanding the change..

Powered by Google App Engine
This is Rietveld 408576698