Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1890)

Unified Diff: net/disk_cache/simple/simple_util.h

Issue 651063002: Deflake Simple Cache backend on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: C4800 Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/simple/simple_util.h
diff --git a/net/disk_cache/simple/simple_util.h b/net/disk_cache/simple/simple_util.h
index b6ca85bb23be044c63296202e408ee183449e2de..24bfa0b4c3d4c20892f4380d04fd3a3cfa03bbc0 100644
--- a/net/disk_cache/simple/simple_util.h
+++ b/net/disk_cache/simple/simple_util.h
@@ -69,7 +69,14 @@ NET_EXPORT_PRIVATE int GetFileIndexFromStreamIndex(int stream_index);
// functions in file.h, the time resolution is milliseconds.
NET_EXPORT_PRIVATE bool GetMTime(const base::FilePath& path,
base::Time* out_mtime);
-} // namespace simple_backend
+
+// Deletes a file, insuring POSIX semantics. Provided that all open handles to
+// this file were opened with File::FLAG_SHARE_DELETE, it is possible to delete
pasko 2014/10/29 13:01:01 I would say "Emulates deleting the file", but I'll
+// an open file and continue to use that file. After deleting an open file, it
+// is possible to immediately create a new file with the same name.
+NET_EXPORT_PRIVATE bool SimpleCacheDeleteFile(const base::FilePath& path);
+
+} // namespace simple_util
} // namespace disk_cache

Powered by Google App Engine
This is Rietveld 408576698