Deflake Simple Cache backend on Windows.

net/disk_cache/simple/simple_util_win.cc

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/disk_cache/simple/simple_util.h"
+
+#include <windows.h>
+
+#include "base/files/file_util.h"
+#include "base/format_macros.h"
+#include "base/rand_util.h"
+#include "base/strings/stringprintf.h"
+#include "net/disk_cache/cache_util.h"
+
+namespace disk_cache {
+namespace simple_util {
+
+bool SimpleCacheDeleteFile(const base::FilePath& path) {

[mmenke, 2014/10/28 20:07:43]

Per offline discussion, this could be a little clearer - add comment, split up
conditional.

+  const base::FilePath rename_target =
+      path.DirName().AppendASCII(base::StringPrintf("todelete_%016" PRIx64,
+                                                    base::RandUint64()));
+
+  const base::FilePath to_delete_file =
+      MoveFile(path.value().c_str(), rename_target.value().c_str()) ?
+          rename_target : path;
+
+  return DeleteCacheFile(to_delete_file);
+}
+
+}  // namespace simple_util
+}  // namespace disk_cache