Chromium Code Reviews
Help | Chromium Project | Sign in
(20)

Issue 651055: Make dynamic access to SSLSetSessionOption static (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by Mark Mentovai
Modified:
3 years, 11 months ago
Reviewers:
wtc, Jens Alfke
CC:
chromium-reviews
Visibility:
Public.

Description

Make dynamic access to SSLSetSessionOption static. It's not often that you can make something both dynamic and static. BUG=16831 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39485

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/socket/ssl_client_socket_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
Mark Mentovai
5 years, 1 month ago (2010-02-19 19:20:47 UTC) #1
Jens Alfke
LTGM. There shouldn't be any threading issues here, right? Even in case of a race ...
5 years, 1 month ago (2010-02-19 19:25:33 UTC) #2
Mark Mentovai
snej@chromium.org wrote: > LTGM. There shouldn't be any threading issues here, right? Even in case ...
5 years, 1 month ago (2010-02-19 19:31:51 UTC) #3
wtc
5 years, 1 month ago (2010-02-20 04:57:38 UTC) #4
Re: thread safety: In Chrome, SSLClientSocket is always used
on the IO thread.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 700cc9d