Issue 651044: Fix SSLSessionOption's name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 651044: Fix SSLSessionOption's name (Closed)

Created:
10 years, 10 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
wtc, Jens Alfke

CC:
chromium-reviews, John Grabowski, darin+cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix SSLSessionOption's name. It's not SSLSetSessionOptionType. Getting the name right is important if this code is to compile with both the 10.5 SDK (where we define the type) and the 10.6 SDK (where the system defines it). The error was introduced in r39389. BUG=16831 TEST=10.6 SDK build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39467

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	net/socket/ssl_client_socket_mac.cc	View	1	2 chunks	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

http://codereview.chromium.org/651044/diff/3/1003 File net/socket/ssl_client_socket_mac.cc (right): http://codereview.chromium.org/651044/diff/3/1003#newcode729 net/socket/ssl_client_socket_mac.cc:729: SSLSetSessionOptionFuncPtr ssl_set_session_options = On an unrelated note, you should ...

10 years, 10 months ago (2010-02-19 17:50:37 UTC) #1

Jens Alfke

10 years, 10 months ago (2010-02-19 18:42:45 UTC) #3

LGTM. If you could add the 'static' keyword you suggested, that would be great
too.

http://codereview.chromium.org/651044/diff/3/1003
File net/socket/ssl_client_socket_mac.cc (right):

http://codereview.chromium.org/651044/diff/3/1003#newcode729
net/socket/ssl_client_socket_mac.cc:729: SSLSetSessionOptionFuncPtr
ssl_set_session_options =
On 2010/02/19 17:50:37, Mark Mentovai wrote:
> On an unrelated note, you should really consider making this static.

Good point, since function lookup could be slow. Would you mind making the
change in this patch?

Expand Messages | Collapse Messages