Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 651044: Fix SSLSessionOption's name (Closed)

Created:
7 years, 9 months ago by Mark Mentovai
Modified:
6 years, 6 months ago
Reviewers:
wtc, Jens Alfke
CC:
chromium-reviews, John Grabowski, darin+cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Fix SSLSessionOption's name. It's not SSLSetSessionOptionType. Getting the name right is important if this code is to compile with both the 10.5 SDK (where we define the type) and the 10.6 SDK (where the system defines it). The error was introduced in r39389. BUG=16831 TEST=10.6 SDK build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39467

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/socket/ssl_client_socket_mac.cc View 1 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
http://codereview.chromium.org/651044/diff/3/1003 File net/socket/ssl_client_socket_mac.cc (right): http://codereview.chromium.org/651044/diff/3/1003#newcode729 net/socket/ssl_client_socket_mac.cc:729: SSLSetSessionOptionFuncPtr ssl_set_session_options = On an unrelated note, you should ...
7 years, 9 months ago (2010-02-19 17:50:37 UTC) #1
wtc
LGTM. Thanks, Mark.
7 years, 9 months ago (2010-02-19 18:06:38 UTC) #2
Jens Alfke
7 years, 9 months ago (2010-02-19 18:42:45 UTC) #3
LGTM. If you could add the 'static' keyword you suggested, that would be great
too.

http://codereview.chromium.org/651044/diff/3/1003
File net/socket/ssl_client_socket_mac.cc (right):

http://codereview.chromium.org/651044/diff/3/1003#newcode729
net/socket/ssl_client_socket_mac.cc:729: SSLSetSessionOptionFuncPtr
ssl_set_session_options =
On 2010/02/19 17:50:37, Mark Mentovai wrote:
> On an unrelated note, you should really consider making this static.

Good point, since function lookup could be slow. Would you mind making the
change in this patch?

Powered by Google App Engine
This is Rietveld efc10ee0f