Chromium Code Reviews
Help | Chromium Project | Sign in
(350)

Issue 651044: Fix SSLSessionOption's name (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by Mark Mentovai
Modified:
2 years, 11 months ago
Reviewers:
wtc, Jens Alfke
CC:
chromium-reviews_chromium.org, John Grabowski, darin+cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Fix SSLSessionOption's name. It's not SSLSetSessionOptionType.

Getting the name right is important if this code is to compile with both the
10.5 SDK (where we define the type) and the 10.6 SDK (where the system defines
it). The error was introduced in r39389.

BUG=16831
TEST=10.6 SDK build

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39467

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Lint Patch
M net/socket/ssl_client_socket_mac.cc View 1 2 chunks +2 lines, -2 lines 2 comments 0 errors Download
Commit:

Messages

Total messages: 3
Mark Mentovai
http://codereview.chromium.org/651044/diff/3/1003 File net/socket/ssl_client_socket_mac.cc (right): http://codereview.chromium.org/651044/diff/3/1003#newcode729 net/socket/ssl_client_socket_mac.cc:729: SSLSetSessionOptionFuncPtr ssl_set_session_options = On an unrelated note, you should ...
4 years, 1 month ago #1
wtc
LGTM. Thanks, Mark.
4 years, 1 month ago #2
Jens Alfke
4 years, 1 month ago #3
LGTM. If you could add the 'static' keyword you suggested, that would be great
too.

http://codereview.chromium.org/651044/diff/3/1003
File net/socket/ssl_client_socket_mac.cc (right):

http://codereview.chromium.org/651044/diff/3/1003#newcode729
net/socket/ssl_client_socket_mac.cc:729: SSLSetSessionOptionFuncPtr
ssl_set_session_options =
On 2010/02/19 17:50:37, Mark Mentovai wrote:
> On an unrelated note, you should really consider making this static.

Good point, since function lookup could be slow. Would you mind making the
change in this patch?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6