Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

Issue 650993004: Cleanup invalidation reason strings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/InspectorTraceEvents.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.TimelineUIUtils} 7 * @extends {WebInspector.TimelineUIUtils}
8 */ 8 */
9 WebInspector.TracingTimelineUIUtils = function() 9 WebInspector.TracingTimelineUIUtils = function()
10 { 10 {
(...skipping 799 matching lines...) Expand 10 before | Expand all | Expand 10 after
810 if (node) 810 if (node)
811 nodeRow.appendChild(WebInspector.DOMPresentationUtils.linkifyNodeRef erence(node)); 811 nodeRow.appendChild(WebInspector.DOMPresentationUtils.linkifyNodeRef erence(node));
812 else if (invalidation.nodeName) 812 else if (invalidation.nodeName)
813 nodeRow.textContent = WebInspector.UIString("[ %s ]", invalidation.n odeName); 813 nodeRow.textContent = WebInspector.UIString("[ %s ]", invalidation.n odeName);
814 else 814 else
815 nodeRow.textContent = WebInspector.UIString("[ unknown node ]"); 815 nodeRow.textContent = WebInspector.UIString("[ unknown node ]");
816 816
817 if (invalidation.reason) { 817 if (invalidation.reason) {
818 var reasonRow = row.createChild("div"); 818 var reasonRow = row.createChild("div");
819 var reason = invalidation.reason; 819 var reason = invalidation.reason;
820 // We should clean up invalidation strings so they are consistent: c rbug.com/424451. 820 reasonRow.textContent = WebInspector.UIString("Reason: %s.", reason) ;
821 if (!invalidation.reason.endsWith("."))
822 reason += ".";
823 reasonRow.textContent = WebInspector.UIString("Reason: %s", reason);
824 } 821 }
825 822
826 if (invalidation.stackTrace) 823 if (invalidation.stackTrace)
827 contentHelper.createChildStackTraceElement(row, invalidation.stackTr ace); 824 contentHelper.createChildStackTraceElement(row, invalidation.stackTr ace);
828 } 825 }
829 } 826 }
830 827
831 /** 828 /**
832 * @param {!WebInspector.TracingModel.Event} event 829 * @param {!WebInspector.TracingModel.Event} event
833 * @param {function(?Array.<number>, ?Array.<number>)} callback 830 * @param {function(?Array.<number>, ?Array.<number>)} callback
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
983 return result; 980 return result;
984 } 981 }
985 982
986 /** 983 /**
987 * @return {!WebInspector.TracingTimelineModel.Filter} 984 * @return {!WebInspector.TracingTimelineModel.Filter}
988 */ 985 */
989 WebInspector.TracingTimelineUIUtils.hiddenEventsFilter = function() 986 WebInspector.TracingTimelineUIUtils.hiddenEventsFilter = function()
990 { 987 {
991 return new WebInspector.TracingTimelineModel.InclusiveEventNameFilter(WebIns pector.TracingTimelineUIUtils._visibleTypes()); 988 return new WebInspector.TracingTimelineModel.InclusiveEventNameFilter(WebIns pector.TracingTimelineUIUtils._visibleTypes());
992 } 989 }
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorTraceEvents.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698