Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 650963003: [Telemetry] Always use ephemeral port chosen by Chrome. (Closed)

Created:
6 years, 2 months ago by tonyg
Modified:
6 years, 2 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Always use ephemeral port chosen by Chrome. This reduces a potential source of flake for desktop Chrome. The reference builds are now M37 (and I've verified they behave properly) and stable is now M38. BUG=379980 Committed: https://crrev.com/f71a95de8adcd6cab36f87d669feda3fb1984896 Cr-Commit-Position: refs/heads/master@{#299621}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -51 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 2 chunks +33 lines, -38 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_options.py View 2 chunks +0 lines, -6 lines 1 comment Download
M tools/telemetry/telemetry/core/browser_options_unittest.py View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tonyg
6 years, 2 months ago (2014-10-13 21:19:58 UTC) #2
dtu
lgtm
6 years, 2 months ago (2014-10-14 00:09:41 UTC) #3
Ken Russell (switch to Gerrit)
LGTM. Thanks for cleaning this up. https://codereview.chromium.org/650963003/diff/1/tools/telemetry/telemetry/core/browser_options.py File tools/telemetry/telemetry/core/browser_options.py (right): https://codereview.chromium.org/650963003/diff/1/tools/telemetry/telemetry/core/browser_options.py#newcode248 tools/telemetry/telemetry/core/browser_options.py:248: group.add_option('--use-devtools-active-port', We should ...
6 years, 2 months ago (2014-10-14 05:57:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650963003/1
6 years, 2 months ago (2014-10-15 00:40:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 01:44:21 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f71a95de8adcd6cab36f87d669feda3fb1984896 Cr-Commit-Position: refs/heads/master@{#299621}
6 years, 2 months ago (2014-10-15 01:46:36 UTC) #8
tonyg
6 years, 2 months ago (2014-10-16 17:26:15 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/659923003/ by tonyg@chromium.org.

The reason for reverting is: Possibly caused flake. Will reland if mistaken.

BUG=424245.

Powered by Google App Engine
This is Rietveld 408576698