Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 650943002: Remove unused Paint() method in WebMediaPlayer. (Closed)

Created:
6 years, 2 months ago by dshwang
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unused Paint() method in WebMediaPlayer. The signiture of this method is changed, so old Paint() method is removed. BUG=407079 Committed: https://crrev.com/257574176b504da41edda7ea8448618d60d371e7 Cr-Commit-Position: refs/heads/master@{#299323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dshwang
Could you review this simple clean-up CL? I changed Paint() signature in https://codereview.chromium.org/443873005
6 years, 2 months ago (2014-10-13 17:34:55 UTC) #2
dshwang
On 2014/10/13 17:34:55, dshwang wrote: > Could you review this simple clean-up CL? > I ...
6 years, 2 months ago (2014-10-13 17:36:49 UTC) #3
scherkus (not reviewing)
lgtm
6 years, 2 months ago (2014-10-13 17:49:40 UTC) #4
dshwang
On 2014/10/13 17:49:40, scherkus wrote: > lgtm Thank you for fast review!
6 years, 2 months ago (2014-10-13 18:02:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650943002/1
6 years, 2 months ago (2014-10-13 18:04:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 18:25:07 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 18:26:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/257574176b504da41edda7ea8448618d60d371e7
Cr-Commit-Position: refs/heads/master@{#299323}

Powered by Google App Engine
This is Rietveld 408576698