Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: sky/engine/core/loader/MojoLoader.h

Issue 650903006: Factor DrainDataPipeJob out of MojoLoader (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/loader/MojoLoader.h
diff --git a/sky/engine/core/loader/MojoLoader.h b/sky/engine/core/loader/MojoLoader.h
index cecc785ba152d3b91f6e470f2d8e18550ce0c953..f239cf74123aaa19ae60c4b159f121509ee3f034 100644
--- a/sky/engine/core/loader/MojoLoader.h
+++ b/sky/engine/core/loader/MojoLoader.h
@@ -8,13 +8,14 @@
#include "base/memory/weak_ptr.h"
#include "mojo/common/handle_watcher.h"
#include "mojo/public/cpp/system/data_pipe.h"
+#include "platform/fetcher/DrainDataPipeJob.h"
#include "platform/weborigin/KURL.h"
namespace blink {
class LocalFrame;
-class MojoLoader {
+class MojoLoader : public DrainDataPipeJob::Client {
public:
explicit MojoLoader(LocalFrame&);
@@ -23,14 +24,11 @@ public:
private:
LocalFrame& m_frame;
- // FIXME: These belong on a helper object for async reading from mojo pipes.
- void readMore();
- void waitToReadMore();
- void moreDataReady(MojoResult);
+ // From DrainDataPipeJob::Client
+ void OnDataAvailable(const void* data, size_t numberOfBytes) override;
+ void OnDataComplete() override;
- mojo::common::HandleWatcher m_handleWatcher;
- mojo::ScopedDataPipeConsumerHandle m_responseStream;
- base::WeakPtrFactory<MojoLoader> m_weakFactory;
+ OwnPtr<DrainDataPipeJob> m_drainJob;
};
}
« no previous file with comments | « no previous file | sky/engine/core/loader/MojoLoader.cpp » ('j') | sky/engine/platform/fetcher/DrainDataPipeJob.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698