Issue 650903006: Factor DrainDataPipeJob out of MojoLoader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 650903006: Factor DrainDataPipeJob out of MojoLoader (Closed)

Created:
6 years, 2 months ago by abarth-chromium

Modified:
6 years, 2 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn

Base URL:
git@github.com:domokit/mojo.git@master

Visibility:
Public.

More Reviews

Description

Factor DrainDataPipeJob out of MojoLoader We want to re-use the code for draining Mojo data pipes in more places that just the MojoLoader. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8a902ddc035bfbddbdfa74706283e87f2742993e

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -35 lines)			Patch
M	sky/engine/core/loader/MojoLoader.h	View	2 chunks	+6 lines, -8 lines	0 comments	Download
M	sky/engine/core/loader/MojoLoader.cpp	View	2 chunks	+5 lines, -27 lines	0 comments	Download
M	sky/engine/platform/BUILD.gn	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	sky/engine/platform/DEPS	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	sky/engine/platform/fetcher/DrainDataPipeJob.h	View	1 chunk	+44 lines, -0 lines	1 comment	Download
A	sky/engine/platform/fetcher/DrainDataPipeJob.cpp	View	1 chunk	+52 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eseidel

https://codereview.chromium.org/650903006/diff/1/sky/engine/platform/fetcher/DrainDataPipeJob.h File sky/engine/platform/fetcher/DrainDataPipeJob.h (right): https://codereview.chromium.org/650903006/diff/1/sky/engine/platform/fetcher/DrainDataPipeJob.h#newcode14 sky/engine/platform/fetcher/DrainDataPipeJob.h:14: class DrainDataPipeJob { DataPipeDrainer? I have trouble with this ...

6 years, 2 months ago (2014-10-24 19:00:43 UTC) #2

abarth-chromium

6 years, 2 months ago (2014-10-24 19:05:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8a902ddc035bfbddbdfa74706283e87f2742993e (presubmit successful).

Expand Messages | Collapse Messages