Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 650903002: File VideoCaptureDevice: Add API type for Windows platforms. (Closed)

Created:
6 years, 2 months ago by mcasas
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

File VideoCaptureDevice: Add API type for Windows platforms. It was missing and causes troubles in browser_tests as seen in the bug. BUG=422954 Committed: https://crrev.com/c22f23aee4cb56aaf20061293853db7da4b7646d Cr-Commit-Position: refs/heads/master@{#299451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M media/video/capture/file_video_capture_device_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
mcasas
perkj@ PTAL xians@ FYI.
6 years, 2 months ago (2014-10-13 14:43:33 UTC) #2
no longer working on chromium
lgtm
6 years, 2 months ago (2014-10-14 08:25:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650903002/1
6 years, 2 months ago (2014-10-14 08:26:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/17451)
6 years, 2 months ago (2014-10-14 08:31:37 UTC) #7
perkj_chrome
lgtm
6 years, 2 months ago (2014-10-14 09:15:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650903002/1
6 years, 2 months ago (2014-10-14 09:16:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 09:43:03 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 09:43:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c22f23aee4cb56aaf20061293853db7da4b7646d
Cr-Commit-Position: refs/heads/master@{#299451}

Powered by Google App Engine
This is Rietveld 408576698