Buildfix for no-args cases to RenderCdmFactory.

Buildfix for no-args cases to RenderCdmFactory.

R=xhwang@chromium.org,jamesr@chromium.org
BUG=None

Committed: https://crrev.com/618be0a5e27b9b0d5e4a1803da8515a54281973a
Cr-Commit-Position: refs/heads/master@{#300511}

[gunsch, 2014-10-21 00:38:17]

gunsch@chromium.org changed required reviewers:
+ jamesr@chromium.org, xhwang@chromium.org

[gunsch, 2014-10-21 00:38:17]

The following issues broke the Chromecast build:

---

../../content/renderer/media/crypto/encrypted_media_player_support_impl.cc:183:33:
error: empty parentheses interpreted as a function declaration
[-Werror,-Wvexing-parse]
    RenderCdmFactory cdm_factory(
                                ^
../../content/renderer/media/crypto/encrypted_media_player_support_impl.cc:183:33:
note: remove parentheses to declare a variable
    RenderCdmFactory cdm_factory(

---

../../content/renderer/render_frame_impl.cc:1710:31: error: empty parentheses
interpreted as a function declaration [-Werror,-Wvexing-parse]
  RenderCdmFactory cdm_factory(
                              ^
../../content/renderer/render_frame_impl.cc:1710:31: note: remove parentheses to
declare a variable
  RenderCdmFactory cdm_factory(
                              ^

[xhwang, 2014-10-21 00:39:53]

Sorry about that. LGTM!

[jamesr, 2014-10-21 00:43:38]

lgtm

does this configuration have any public buildbots?

https://codereview.chromium.org/650853003/diff/1/content/renderer/media/crypt...
File content/renderer/media/crypto/encrypted_media_player_support_impl.cc
(right):

https://codereview.chromium.org/650853003/diff/1/content/renderer/media/crypt...
content/renderer/media/crypto/encrypted_media_player_support_impl.cc:185:
(base::Bind(&PepperCdmWrapperImpl::Create, frame))
at this point sharing the variable declaration isn't worth it, imo.  i'd do

#if defined(ENABLE_PEPPER_CDMS)
  RenderCdmFactory cdm_factory(base::Bind...));
#else
  RenderCdmFactory cdm_factory;
#endif

to make the two versions more readable

[gunsch, 2014-10-21 00:50:28]

No trybot yet for chromecast's build. We've been asking for some time
(crbug/412499) but have (outside the bug) been told it's been deprioritized with
no ETA.

https://codereview.chromium.org/650853003/diff/1/content/renderer/media/crypt...
File content/renderer/media/crypto/encrypted_media_player_support_impl.cc
(right):

https://codereview.chromium.org/650853003/diff/1/content/renderer/media/crypt...
content/renderer/media/crypto/encrypted_media_player_support_impl.cc:185:
(base::Bind(&PepperCdmWrapperImpl::Create, frame))
On 2014/10/21 00:43:38, jamesr wrote:
> at this point sharing the variable declaration isn't worth it, imo.  i'd do
> 
> #if defined(ENABLE_PEPPER_CDMS)
>   RenderCdmFactory cdm_factory(base::Bind...));
> #else
>   RenderCdmFactory cdm_factory;
> #endif
> 
> to make the two versions more readable

Done.

[jamesr, 2014-10-21 00:54:02]

lgtm

https://codereview.chromium.org/650853003/diff/20001/content/renderer/media/c...
File content/renderer/media/crypto/encrypted_media_player_support_impl.cc
(right):

https://codereview.chromium.org/650853003/diff/20001/content/renderer/media/c...
content/renderer/media/crypto/encrypted_media_player_support_impl.cc:183:
RenderCdmFactory cdm_factory
same feedback goes for here

[gunsch, 2014-10-21 16:25:17]

The CQ bit was checked by gunsch@chromium.org

[gunsch, 2014-10-21 16:25:27]

https://codereview.chromium.org/650853003/diff/20001/content/renderer/media/c...
File content/renderer/media/crypto/encrypted_media_player_support_impl.cc
(right):

https://codereview.chromium.org/650853003/diff/20001/content/renderer/media/c...
content/renderer/media/crypto/encrypted_media_player_support_impl.cc:183:
RenderCdmFactory cdm_factory
On 2014/10/21 00:54:02, jamesr wrote:
> same feedback goes for here

Done.

[commit-bot: I haz the power, 2014-10-21 16:27:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/650853003/40001

[commit-bot: I haz the power, 2014-10-21 17:21:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-21 17:22:37]

Patchset 3 (id:??) landed as
https://crrev.com/618be0a5e27b9b0d5e4a1803da8515a54281973a
Cr-Commit-Position: refs/heads/master@{#300511}