Issue 650843002: [turbofan] Embed the actual backing store address for typed loads/stores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 650843002: [turbofan] Embed the actual backing store address for typed loads/stores. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer

Modified:
6 years, 2 months ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Embed the actual backing store address for typed loads/stores. TEST=unittests R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24548

Patch Set 4 : Add comment. #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -43 lines)			Patch
M	src/compiler/common-node-cache.h	View		2 chunks	+9 lines, -3 lines	0 comments	Download
M	src/compiler/js-graph.h	View	1 2 3	1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/compiler/js-graph.cc	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	src/compiler/js-typed-lowering.cc	View	1	2 chunks	+8 lines, -12 lines	0 comments	Download
M	test/unittests/compiler/js-typed-lowering-unittest.cc	View	1 2	4 chunks	+16 lines, -28 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

dcarney

lgtm https://codereview.chromium.org/650843002/diff/110001/src/compiler/js-graph.h File src/compiler/js-graph.h (right): https://codereview.chromium.org/650843002/diff/110001/src/compiler/js-graph.h#newcode78 src/compiler/js-graph.h:78: // Creates a Int32Constant/Int64Constant node, depending on the ...

6 years, 2 months ago (2014-10-13 09:11:49 UTC) #3

Benedikt Meurer

6 years, 2 months ago (2014-10-13 09:17:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:150001) manually as 24548 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 650843002: [turbofan] Embed the actual backing store address for typed loads/stores. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix win64. #

Patch Set 3 : Cleanups #

Patch Set 4 : Add comment. #

Messages