Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1754)

Unified Diff: WebCore/ChangeLog

Issue 6508002: Revert 78166 - Merge r77114 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/597/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 78370)
+++ WebCore/ChangeLog (working copy)
@@ -1,34 +1,3 @@
-2011-01-30 Kenichi Ishibashi <bashi@google.com>
-
- Reviewed by Kent Tamura.
-
- Dangling form associated elements should not be registered on the document
- https://bugs.webkit.org/show_bug.cgi?id=53223
-
- Adds insertedIntoDocument() and remvoedFromDocument() to
- FormAssociatedElement class to register the element on the document
- if and only if it actually inserted into (removed from) the document.
-
- Test: fast/forms/dangling-form-element-crash.html
-
- * html/FormAssociatedElement.cpp:
- (WebCore::FormAssociatedElement::insertedIntoDocument): Added.
- (WebCore::FormAssociatedElement::removedFromDocument): Ditto.
- (WebCore::FormAssociatedElement::insertedIntoTree): Don't register
- the element to a document.
- (WebCore::FormAssociatedElement::removedFromTree): Don't unregister
- the element from a document.
- * html/FormAssociatedElement.h:
- * html/HTMLFormControlElement.cpp:
- (WebCore::HTMLFormControlElement::insertedIntoDocument): Added.
- (WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
- * html/HTMLFormControlElement.h:
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::insertedIntoDocument): Calls
- FormAssociatedElement::insertedIntoDocument().
- (WebCore::HTMLObjectElement::removedFromDocument): Calls
- FormAssociatedElement::removedFromDocument().
-
2011-02-02 Chris Evans <cevans@chromium.org>
Reviewed by Darin Fisher.
« no previous file with comments | « LayoutTests/fast/forms/dangling-form-element-crash-expected.txt ('k') | WebCore/html/HTMLFormControlElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698