| OLD | NEW |
|---|
| 1 2011-01-30 Kenichi Ishibashi <bashi@google.com> | |
| 2 | |
| 3 Reviewed by Kent Tamura. | |
| 4 | |
| 5 Dangling form associated elements should not be registered on the docume
nt | |
| 6 https://bugs.webkit.org/show_bug.cgi?id=53223 | |
| 7 | |
| 8 Adds insertedIntoDocument() and remvoedFromDocument() to | |
| 9 FormAssociatedElement class to register the element on the document | |
| 10 if and only if it actually inserted into (removed from) the document. | |
| 11 | |
| 12 Test: fast/forms/dangling-form-element-crash.html | |
| 13 | |
| 14 * html/FormAssociatedElement.cpp: | |
| 15 (WebCore::FormAssociatedElement::insertedIntoDocument): Added. | |
| 16 (WebCore::FormAssociatedElement::removedFromDocument): Ditto. | |
| 17 (WebCore::FormAssociatedElement::insertedIntoTree): Don't register | |
| 18 the element to a document. | |
| 19 (WebCore::FormAssociatedElement::removedFromTree): Don't unregister | |
| 20 the element from a document. | |
| 21 * html/FormAssociatedElement.h: | |
| 22 * html/HTMLFormControlElement.cpp: | |
| 23 (WebCore::HTMLFormControlElement::insertedIntoDocument): Added. | |
| 24 (WebCore::HTMLFormControlElement::removedFromDocument): Ditto. | |
| 25 * html/HTMLFormControlElement.h: | |
| 26 * html/HTMLObjectElement.cpp: | |
| 27 (WebCore::HTMLObjectElement::insertedIntoDocument): Calls | |
| 28 FormAssociatedElement::insertedIntoDocument(). | |
| 29 (WebCore::HTMLObjectElement::removedFromDocument): Calls | |
| 30 FormAssociatedElement::removedFromDocument(). | |
| 31 | |
| 32 2011-02-02 Chris Evans <cevans@chromium.org> | 1 2011-02-02 Chris Evans <cevans@chromium.org> |
| 33 | 2 |
| 34 Reviewed by Darin Fisher. | 3 Reviewed by Darin Fisher. |
| 35 | 4 |
| 36 window.find() can fail when switching case sensitivity | 5 window.find() can fail when switching case sensitivity |
| 37 https://bugs.webkit.org/show_bug.cgi?id=53654 | 6 https://bugs.webkit.org/show_bug.cgi?id=53654 |
| 38 | 7 |
| 39 Reset the pattern to a safe one when done, to avoid usearch_reset() | 8 Reset the pattern to a safe one when done, to avoid usearch_reset() |
| 40 indirectly touching the old, stale text pointer. | 9 indirectly touching the old, stale text pointer. |
| 41 | 10 |
| (...skipping 2755 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 2797 (WebCore::ScriptCallFrame::buildInspectorObject): | 2766 (WebCore::ScriptCallFrame::buildInspectorObject): |
| 2798 * inspector/ScriptCallFrame.h: | 2767 * inspector/ScriptCallFrame.h: |
| 2799 (WebCore::ScriptCallFrame::sourceURL): | 2768 (WebCore::ScriptCallFrame::sourceURL): |
| 2800 * inspector/ScriptCallStack.h: | 2769 * inspector/ScriptCallStack.h: |
| 2801 * inspector/TimelineRecordFactory.cpp: | 2770 * inspector/TimelineRecordFactory.cpp: |
| 2802 (WebCore::TimelineRecordFactory::createGenericRecord): | 2771 (WebCore::TimelineRecordFactory::createGenericRecord): |
| 2803 * inspector/front-end/ConsoleView.js: | 2772 * inspector/front-end/ConsoleView.js: |
| 2804 (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement): | 2773 (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement): |
| 2805 | 2774 |
| 2806 == Rolled over to ChangeLog-2010-12-06 == | 2775 == Rolled over to ChangeLog-2010-12-06 == |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 6508002:
Revert 78166 - Merge r77114 (Closed)
Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/597/