Delay default apps installation on Chrome OS for first time sign-in

chrome/browser/extensions/external_provider_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/external_provider_impl.h"
 
 #include <set>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 478 matching lines @@
                 Manifest::EXTERNAL_PREF_DOWNLOAD,
                 bundled_extension_creation_flags)));
   }
 #endif
 
 #if defined(OS_CHROMEOS)
   if (!is_chromeos_demo_session && !is_chrome_os_public_session) {
     int external_apps_path_id = profile->IsSupervised() ?
         chrome::DIR_SUPERVISED_USERS_DEFAULT_APPS :
         chrome::DIR_STANDALONE_EXTERNAL_EXTENSIONS;
+    ExternalPrefLoader::Options pref_load_flags = profile->IsNewProfile() ?
+        ExternalPrefLoader::DELAY_LOAD : ExternalPrefLoader::NONE;

[asargent_no_longer_on_chrome, 2014/10/23 22:34:35]

A thought just occurred to me - is there a way to know that priority pref
settings coming down via sync are pending, or complete? E.g. it would be nice if
there weren't pending settings to just start this immediately, or if the
settings arrived say after 8 seconds, to not have to wait the extra 7 seconds to
begin installing default apps. 

If this bug is urgent or that's a more complicated change than you want to take
on for now, that could certainly just be logged as a follow-up bug or something
(if you agree it's even a good idea). 

[Dmitry Polukhin, 2014/10/24 11:40:42]

Good idea, done.

     provider_list->push_back(
         linked_ptr<ExternalProviderInterface>(new ExternalProviderImpl(
             service,
             new ExternalPrefLoader(external_apps_path_id,
-                                   ExternalPrefLoader::NONE),
+                                   pref_load_flags),
             profile,
             Manifest::EXTERNAL_PREF,
             Manifest::EXTERNAL_PREF_DOWNLOAD,
             bundled_extension_creation_flags)));
 
     // OEM default apps.
     int oem_extension_creation_flags =

[Nikita (slow), 2014/10/23 14:24:16]

What about OEM default apps?

[Dmitry Polukhin, 2014/10/24 11:40:42]

I don't postponed apps from sync installation so there is no sense to block OEM
default apps. Especially because these ones for LOEM and should require manifest
fetch and most probably light weight. Will reconsider later if it pops up.

         bundled_extension_creation_flags | Extension::WAS_INSTALLED_BY_OEM;
     chromeos::ServicesCustomizationDocument* customization =
         chromeos::ServicesCustomizationDocument::GetInstance();
     provider_list->push_back(linked_ptr<ExternalProviderInterface>(
         new ExternalProviderImpl(service,
                                  customization->CreateExternalLoader(profile),
                                  profile,
                                  Manifest::EXTERNAL_PREF,
                                  Manifest::EXTERNAL_PREF_DOWNLOAD,
                                  oem_extension_creation_flags)));
@@ skipping 76 matching lines @@
             service,
             new ExternalComponentLoader(profile),
             profile,
             Manifest::INVALID_LOCATION,
             Manifest::EXTERNAL_COMPONENT,
             Extension::FROM_WEBSTORE | Extension::WAS_INSTALLED_BY_DEFAULT)));
   }
 }
 
 }  // namespace extensions