Issue 650663003: harmony-scoping: Correct dynamic lookups on a top level.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 650663003: harmony-scoping: Correct dynamic lookups on a top level. (Closed)

Created:
6 years, 1 month ago by Dmitry Lomov (no reviews)

Modified:
6 years, 1 month ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

harmony-scoping: Correct dynamic lookups on a top level. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24975

Patch Set 2 : CR feedback + rebase #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -1 line)			Patch
	M	src/contexts.cc	View	1	2 chunks	+19 lines, -1 line	0 comments	Download
	M	test/cctest/test-decls.cc	View		1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

LGTM, up to comment https://codereview.chromium.org/650663003/diff/1/src/contexts.cc File src/contexts.cc (right): https://codereview.chromium.org/650663003/diff/1/src/contexts.cc#newcode138 src/contexts.cc:138: context = Handle<Context>(context->global_object()->global_context()); Add a ...

6 years, 1 month ago (2014-10-29 06:37:17 UTC) #2

Dmitry Lomov (no reviews)

6 years, 1 month ago (2014-10-29 10:59:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 24975 (presubmit successful).

Expand Messages | Collapse Messages

Issue 650663003: harmony-scoping: Correct dynamic lookups on a top level. (Closed)

Description

Patch Set 1 #

Patch Set 2 : CR feedback + rebase #

Messages