Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 650553002: Allow GCC to build Skia on Mac. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org, bungeman-skia
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Allow GCC to build Skia on Mac. GCC doesn't understand -fasm-blocks or -mpascal-strings, but we don't care about them. While looking around in Gyp, I noticed a better way to disable warnings about offsetof so that it doesn't tell us "disabling this warning makes no sense in C" for every C source file we compile. BUG=skia: Committed: https://skia.googlesource.com/skia/+/335a0ae19c3c26a934b2a25c0b8016a453c4b013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M gyp/common_conditions.gypi View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
mtklein
6 years, 2 months ago (2014-10-10 23:09:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650553002/1
6 years, 2 months ago (2014-10-10 23:10:40 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-10 23:10:40 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 2 months ago (2014-10-11 05:10:48 UTC) #7
reed1
lgtm
6 years, 2 months ago (2014-10-13 12:25:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650553002/1
6 years, 2 months ago (2014-10-13 13:15:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650553002/1
6 years, 2 months ago (2014-10-13 19:32:41 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as 335a0ae19c3c26a934b2a25c0b8016a453c4b013
6 years, 2 months ago (2014-10-13 19:32:46 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 19:32:49 UTC) #15
Message was sent while issue was closed.
Failed to apply the patch.

Powered by Google App Engine
This is Rietveld 408576698