Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 65043023: Revert 235752 "Fix chrome upload with content uri" (Closed)

Created:
7 years, 1 month ago by qinmin
Modified:
7 years, 1 month ago
Reviewers:
qinmin
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 235752 "Fix chrome upload with content uri" > Fix chrome upload with content uri > > For android, the upload file dialog returns files with content uri scheme(content://). > This CL makes it possible for upload to work with this new file type. > It fixes both the form and fileapi based uploads. > > The CL follows the same code path used by regular file upload and the content url is encompassed by a FilePath object. > > R=jar@chromium.org, joth@chromium.org, kinuko@chromium.org, mmenke@chromium.org, tsepez@chromium.org > TBR=yfriedman > BUG=278640 > > Review URL: https://codereview.chromium.org/46303005 TBR=qinmin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -506 lines) Patch
M trunk/src/base/android/base_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D trunk/src/base/android/content_uri_utils.h View 1 chunk +0 lines, -27 lines 0 comments Download
D trunk/src/base/android/content_uri_utils.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D trunk/src/base/android/java/src/org/chromium/base/ContentUriUtils.java View 1 chunk +0 lines, -76 lines 0 comments Download
M trunk/src/base/base.gyp View 6 chunks +0 lines, -33 lines 0 comments Download
M trunk/src/base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/base/file_util_posix.cc View 4 chunks +2 lines, -27 lines 0 comments Download
M trunk/src/base/file_util_unittest.cc View 2 chunks +0 lines, -50 lines 0 comments Download
M trunk/src/base/files/file_path.h View 1 chunk +0 lines, -9 lines 0 comments Download
M trunk/src/base/files/file_path.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/base/files/file_path_unittest.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D trunk/src/base/test/android/java/src/org/chromium/base/ContentUriTestUtils.java View 1 chunk +0 lines, -51 lines 0 comments Download
D trunk/src/base/test/data/file_util/red.png View Binary file 0 comments Download
M trunk/src/base/test/run_all_unittests.cc View 2 chunks +1 line, -9 lines 0 comments Download
M trunk/src/base/test/test_file_util.h View 2 chunks +0 lines, -14 lines 0 comments Download
D trunk/src/base/test/test_file_util_android.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M trunk/src/content/browser/child_process_security_policy_impl.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M trunk/src/net/base/file_stream_context.cc View 2 chunks +7 lines, -22 lines 0 comments Download
M trunk/src/net/base/file_stream_unittest.cc View 2 chunks +0 lines, -53 lines 0 comments Download
D trunk/src/net/data/file_stream_unittest/red.png View Binary file 0 comments Download
M trunk/src/net/net.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/net/test/run_all_unittests.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java View 1 chunk +21 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
qinmin
7 years, 1 month ago (2013-11-18 18:10:38 UTC) #1
qinmin
7 years, 1 month ago (2013-11-18 18:11:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r235760.

Powered by Google App Engine
This is Rietveld 408576698