Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Side by Side Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 65043017: Change the text of 'Always translate ...' and modify the layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/translate/translate_bubble_view.h" 5 #include "chrome/browser/ui/views/translate/translate_bubble_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 660 matching lines...) Expand 10 before | Expand all | Expand 10 after
671 } 671 }
672 672
673 views::View* view = new views::View(); 673 views::View* view = new views::View();
674 views::GridLayout* layout = new views::GridLayout(view); 674 views::GridLayout* layout = new views::GridLayout(view);
675 view->SetLayoutManager(layout); 675 view->SetLayoutManager(layout);
676 676
677 using views::GridLayout; 677 using views::GridLayout;
678 678
679 enum { 679 enum {
680 COLUMN_SET_ID_LANGUAGES, 680 COLUMN_SET_ID_LANGUAGES,
681 COLUMN_SET_ID_ALWAYS_TRANSLATE,
682 COLUMN_SET_ID_BUTTONS, 681 COLUMN_SET_ID_BUTTONS,
683 }; 682 };
684 683
685 views::ColumnSet* cs = layout->AddColumnSet(COLUMN_SET_ID_LANGUAGES); 684 views::ColumnSet* cs = layout->AddColumnSet(COLUMN_SET_ID_LANGUAGES);
686 cs->AddColumn(GridLayout::TRAILING, GridLayout::CENTER, 685 cs->AddColumn(GridLayout::TRAILING, GridLayout::CENTER,
687 0, GridLayout::USE_PREF, 0, 0); 686 0, GridLayout::USE_PREF, 0, 0);
688 cs->AddPaddingColumn(0, views::kRelatedControlHorizontalSpacing); 687 cs->AddPaddingColumn(0, views::kRelatedControlHorizontalSpacing);
689 cs->AddColumn(GridLayout::FILL, GridLayout::CENTER, 688 cs->AddColumn(GridLayout::FILL, GridLayout::CENTER,
690 0, GridLayout::USE_PREF, 0, 0); 689 0, GridLayout::USE_PREF, 0, 0);
691 cs->AddPaddingColumn(1, 0); 690 cs->AddPaddingColumn(1, 0);
692 691
693 if (!is_in_incognito_window_) {
694 cs = layout->AddColumnSet(COLUMN_SET_ID_ALWAYS_TRANSLATE);
695 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER,
696 0, GridLayout::USE_PREF, 0, 0);
697 cs->AddPaddingColumn(1, 0);
698 }
699
700 cs = layout->AddColumnSet(COLUMN_SET_ID_BUTTONS); 692 cs = layout->AddColumnSet(COLUMN_SET_ID_BUTTONS);
701 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 693 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER,
702 0, GridLayout::USE_PREF, 0, 0); 694 0, GridLayout::USE_PREF, 0, 0);
703 cs->AddPaddingColumn(1, views::kUnrelatedControlHorizontalSpacing); 695 cs->AddPaddingColumn(1, views::kUnrelatedControlHorizontalSpacing);
704 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 696 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER,
705 0, GridLayout::USE_PREF, 0, 0); 697 0, GridLayout::USE_PREF, 0, 0);
706 cs->AddPaddingColumn(0, views::kRelatedButtonHSpacing); 698 cs->AddPaddingColumn(0, views::kRelatedButtonHSpacing);
707 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 699 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER,
708 0, GridLayout::USE_PREF, 0, 0); 700 0, GridLayout::USE_PREF, 0, 0);
709 701
710 layout->StartRow(0, COLUMN_SET_ID_LANGUAGES); 702 layout->StartRow(0, COLUMN_SET_ID_LANGUAGES);
711 layout->AddView(source_language_label); 703 layout->AddView(source_language_label);
712 layout->AddView(source_language_combobox_); 704 layout->AddView(source_language_combobox_);
713 705
714 layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing); 706 layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
715 707
716 layout->StartRow(0, COLUMN_SET_ID_LANGUAGES); 708 layout->StartRow(0, COLUMN_SET_ID_LANGUAGES);
717 layout->AddView(target_language_label); 709 layout->AddView(target_language_label);
718 layout->AddView(target_language_combobox_); 710 layout->AddView(target_language_combobox_);
719 711
720 if (!is_in_incognito_window_) { 712 if (!is_in_incognito_window_) {
721 layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing); 713 layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
722 714 layout->StartRow(0, COLUMN_SET_ID_LANGUAGES);
723 layout->StartRow(0, COLUMN_SET_ID_ALWAYS_TRANSLATE); 715 layout->SkipColumns(1);
724 layout->AddView(always_translate_checkbox_); 716 layout->AddView(always_translate_checkbox_);
725 } 717 }
726 718
727 layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing); 719 layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing);
728 720
729 layout->StartRow(0, COLUMN_SET_ID_BUTTONS); 721 layout->StartRow(0, COLUMN_SET_ID_BUTTONS);
730 layout->AddView(CreateLink(this, 722 layout->AddView(CreateLink(this,
731 IDS_TRANSLATE_BUBBLE_LEARN_MORE, 723 IDS_TRANSLATE_BUBBLE_LEARN_MORE,
732 LINK_ID_LEARN_MORE)); 724 LINK_ID_LEARN_MORE));
733 views::LabelButton* cancel_button = CreateLabelButton( 725 views::LabelButton* cancel_button = CreateLabelButton(
(...skipping 21 matching lines...) Expand all
755 747
756 void TranslateBubbleView::UpdateAdvancedView() { 748 void TranslateBubbleView::UpdateAdvancedView() {
757 DCHECK(source_language_combobox_); 749 DCHECK(source_language_combobox_);
758 DCHECK(target_language_combobox_); 750 DCHECK(target_language_combobox_);
759 751
760 string16 source_language_name = 752 string16 source_language_name =
761 model_->GetLanguageNameAt(model_->GetOriginalLanguageIndex()); 753 model_->GetLanguageNameAt(model_->GetOriginalLanguageIndex());
762 string16 target_language_name = 754 string16 target_language_name =
763 model_->GetLanguageNameAt(model_->GetTargetLanguageIndex()); 755 model_->GetLanguageNameAt(model_->GetTargetLanguageIndex());
764 756
765 string16 message =
766 l10n_util::GetStringFUTF16(IDS_TRANSLATE_BUBBLE_ALWAYS,
767 source_language_name,
768 target_language_name);
769 // "Always translate" checkbox doesn't exist in an incognito window. 757 // "Always translate" checkbox doesn't exist in an incognito window.
770 if (always_translate_checkbox_) { 758 if (always_translate_checkbox_) {
771 always_translate_checkbox_->SetText(message); 759 always_translate_checkbox_->SetText(
760 l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_ALWAYS));
772 always_translate_checkbox_->SetChecked( 761 always_translate_checkbox_->SetChecked(
773 model_->ShouldAlwaysTranslate()); 762 model_->ShouldAlwaysTranslate());
774 } 763 }
775 } 764 }
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698