chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm - Issue 65043015: [mac] Implement a windowed extension install/permissions prompt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

Issue 65043015: [mac] Implement a windowed extension install/permissions prompt. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address comments Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

index a4d2efa58a28af49f80ab47a0cab2fd8688cf7d2..c8edfc8d8a01794cfb1a968fd40fe330a55aff55 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

@@ -12,6 +12,7 @@

#import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.h"

#include "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.h"

#import "chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h"

+#import "chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "content/public/browser/web_contents.h"

@@ -21,13 +22,12 @@ void ShowExtensionInstallDialogImpl(

const ExtensionInstallPrompt::ShowParams& show_params,

ExtensionInstallPrompt::Delegate* delegate,

const ExtensionInstallPrompt::Prompt& prompt) {

+ // These objects will delete themselves when the dialog closes.

if (!show_params.parent_web_contents) {

- // TODO(sail): Add support for showing the dialog without a parent window.

- NOTIMPLEMENTED();

+ new WindowedInstallDialogController(show_params, delegate, prompt);

return;

}

- // This object will delete itself when the dialog closes.

new ExtensionInstallDialogController(show_params, delegate, prompt);

}