[mac] Implement a windowed extension install/permissions prompt.

[mac] Implement a windowed extension install/permissions prompt.

This allows extension install dialogs, and permissions upgrade prompts,
to be shown on mac without requiring a parent WebContents to attach a
sheet to. Currently, they hit NOTIMPLEMENTED().

The window is a titled NSPanel, centred on screen using [NSWindow
center]. The implementation mostly uses the existing
ExtensionInstallViewController, but puts it in a new, windowed-version
of ExtensionInstallDialogController.

Adds a test:
WindowedInstallDialogControllerBrowserTest.ShowInstallDialog that mimics
the way extension install and upgrade prompts are invoked via the app
launcher.

Screenshot at http://crbug.com/325030#c2

BUG=325030, 229094, 271809, 269151
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238542

[tapted, 2013-12-03 04:56:40]

HI Robert, could you please take a look for a general Cocoa review?

[Robert Sesek, 2013-12-03 14:47:52]

LGTM

https://codereview.chromium.org/65043015/diff/170001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h
(right):

https://codereview.chromium.org/65043015/diff/170001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h:30: //
Invoked by the -[NSwindow windowWillClose:] notification after a dialog
nit: NSw -> NSW

https://codereview.chromium.org/65043015/diff/170001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm
(right):

https://codereview.chromium.org/65043015/diff/170001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm:14: :
NSWindowController <NSWindowDelegate> {
nit: no space before <

https://codereview.chromium.org/65043015/diff/170001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm:31:
const ExtensionInstallPrompt::Prompt& prompt) : delegate_(delegate) {
nit: I'd put the initializer list on its own line, since the arguments are
already wrapped

[tapted, 2013-12-03 23:11:46]

+thakis for OWNERS in base/mac/sdk_forward_declarations.h - PTAL

https://codereview.chromium.org/65043015/diff/170001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h
(right):

https://codereview.chromium.org/65043015/diff/170001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h:30: //
Invoked by the -[NSwindow windowWillClose:] notification after a dialog
On 2013/12/03 14:47:53, rsesek wrote:
> nit: NSw -> NSW

Done.

https://codereview.chromium.org/65043015/diff/170001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm
(right):

https://codereview.chromium.org/65043015/diff/170001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm:14: :
NSWindowController <NSWindowDelegate> {
On 2013/12/03 14:47:53, rsesek wrote:
> nit: no space before <

Done.

https://codereview.chromium.org/65043015/diff/170001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm:31:
const ExtensionInstallPrompt::Prompt& prompt) : delegate_(delegate) {
On 2013/12/03 14:47:53, rsesek wrote:
> nit: I'd put the initializer list on its own line, since the arguments are
> already wrapped

Done.

[Nico, 2013-12-03 23:13:47]

base/ lgtm

[commit-bot: I haz the power, 2013-12-04 00:13:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/65043015/210001

[commit-bot: I haz the power, 2013-12-04 03:22:53]

Change committed as 238542