Source/core/editing/TypingCommand.h - Issue 65043014: Fix for broken undo functionality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/TypingCommand.h

Issue 65043014: Fix for broken undo functionality (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments incorporated Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/TypingCommand.h

diff --git a/Source/core/editing/TypingCommand.h b/Source/core/editing/TypingCommand.h

index 90a86b906c70d2dd639d6032e3c88a7aa19c6113..05032abe59b0380e01f2c56eb7c6820bd4062c64 100644

--- a/Source/core/editing/TypingCommand.h

+++ b/Source/core/editing/TypingCommand.h

@@ -117,6 +117,9 @@ private:

void typingAddedToOpenCommand(ETypingCommand);

bool makeEditableRootEmpty();

+ void updateCommandTypeOfOpenCommand(ETypingCommand typingCommand) { m_commandType = typingCommand; }

+ ETypingCommand commandTypeOfOpenCommand() const { return m_commandType; }

ETypingCommand m_commandType;

String m_textToInsert;

bool m_openForMoreTyping;