Source/core/editing/TypingCommand.h - Issue 65043014: Fix for broken undo functionality

Side by Side Diff: Source/core/editing/TypingCommand.h

Issue 65043014: Fix for broken undo functionality (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removing old pixel test Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/editing/undo/undo-insert-delete.html ('K') | « LayoutTests/platform/win/editing/undo/5378473-expected.txt ('k') | Source/core/editing/TypingCommand.cpp » ('j') | Source/core/editing/TypingCommand.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.	2 * Copyright (C) 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 99 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
110 virtual bool shouldStopCaretBlinking() const { return true; }	110 virtual bool shouldStopCaretBlinking() const { return true; }

111 void setShouldPreventSpellChecking(bool prevent) { m_shouldPreventSpellCheck ing = prevent; }	111 void setShouldPreventSpellChecking(bool prevent) { m_shouldPreventSpellCheck ing = prevent; }

112	112

113 static void updateSelectionIfDifferentFromCurrentSelection(TypingCommand, F rame);	113 static void updateSelectionIfDifferentFromCurrentSelection(TypingCommand, F rame);

114	114

115 void updatePreservesTypingStyle(ETypingCommand);	115 void updatePreservesTypingStyle(ETypingCommand);

116 void markMisspellingsAfterTyping(ETypingCommand);	116 void markMisspellingsAfterTyping(ETypingCommand);

117 void typingAddedToOpenCommand(ETypingCommand);	117 void typingAddedToOpenCommand(ETypingCommand);

118 bool makeEditableRootEmpty();	118 bool makeEditableRootEmpty();

119	119

	120 void updateCommandTypeOfOpenCommand(ETypingCommand typingCommand) { m_comman dType = typingCommand; }

	121 ETypingCommand commandTypeOfOpenCommand() { return m_commandType; }
	yosin_UTC9 2013/11/15 10:22:22 nit: Should be have \|const\| qualifier. nit: Should be have \|const\| qualifier.
	122

120 ETypingCommand m_commandType;	123 ETypingCommand m_commandType;

121 String m_textToInsert;	124 String m_textToInsert;

122 bool m_openForMoreTyping;	125 bool m_openForMoreTyping;

123 bool m_selectInsertedText;	126 bool m_selectInsertedText;

124 bool m_smartDelete;	127 bool m_smartDelete;

125 TextGranularity m_granularity;	128 TextGranularity m_granularity;

126 TextCompositionType m_compositionType;	129 TextCompositionType m_compositionType;

127 bool m_killRing;	130 bool m_killRing;

128 bool m_preservesTypingStyle;	131 bool m_preservesTypingStyle;

129	132

130 // Undoing a series of backward deletes will restore a selection around all of the	133 // Undoing a series of backward deletes will restore a selection around all of the

131 // characters that were deleted, but only if the typing command being undone	134 // characters that were deleted, but only if the typing command being undone

132 // was opened with a backward delete.	135 // was opened with a backward delete.

133 bool m_openedByBackwardDelete;	136 bool m_openedByBackwardDelete;

134	137

135 bool m_shouldRetainAutocorrectionIndicator;	138 bool m_shouldRetainAutocorrectionIndicator;

136 bool m_shouldPreventSpellChecking;	139 bool m_shouldPreventSpellChecking;

137 };	140 };

138	141

139 } // namespace WebCore	142 } // namespace WebCore

140	143

141 #endif // TypingCommand_h	144 #endif // TypingCommand_h

OLD	NEW