LayoutTests/editing/undo/undo-insert-delete.html - Issue 65043014: Fix for broken undo functionality

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/undo/undo-insert-delete.html

Issue 65043014: Fix for broken undo functionality (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removing old pixel test Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <div id="container">

	5 <p id="description"></p>

	6 <p>To test manually:<br>1. Place the cursor at the end of 'abc'. Delete 'c'. Typ e in 'x'. Delete 'x'. Do ctrl+z. You should now see 'abx'.<br>2. Make sure you h ave the cursor at the end of 'abx'. Type in 'y'. Delete 'y'. Do ctrl+z. You shou ld now see 'abxy'.</p>

	7 <div id="test" style="border: 2px solid red;" contenteditable>abc</div>

	8 </div>

	9 <div id="console"></div>

	10 <script src="../../resources/js-test.js"></script>

	11 <script>

	12 description('Verifies undo functionality that follows text insertion.');

	13

	14 var selection = window.getSelection();

	15 selection.collapse(document.getElementById('test').firstChild, 3);

	16

	17 //Use case 1: Place the cursor at the end of 'abc'. Delete 'c'. Type in 'x'. De lete 'x'. Do ctrl+z. You should now see 'abx'.

	18 document.execCommand('delete');

	19 document.execCommand('insertText', false, 'x');

	20 document.execCommand('delete');

	21 document.execCommand('undo');

	22 shouldBeEqualToString('selection.focusNode.data', 'abx');

	23

	24 // Use case 2: Type in 'y'. Delete 'y'. Do ctrl+z. You should now see 'abxy'.

	25 selection.collapseToEnd(); //This is needed for this test to work on mac platfor m
	yosin_UTC9 2013/11/15 10:22:22 nit: Should have one space after "//". nit: Should have one space after "//".
	26 document.execCommand('insertText', false, 'y');

	27 document.execCommand('delete');

	28 document.execCommand('undo');

	29 shouldBeEqualToString('selection.focusNode.data', 'abxy');

	30

	31 if (window.testRunner)

	32 document.getElementById('container').outerHTML = '';

	33 </script>

	34 </body>

	35 </html>

OLD	NEW