Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 65043011: Have DOMImplementation take the Document argument by reference (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
Reviewers:
adamk, eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Have DOMImplementation take the Document argument by reference Have DOMImplementation take the Document argument by reference as its implementation expected the Document pointer to never be null. This makes the code look safer. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162126

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M Source/core/dom/DOMImplementation.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 1 4 chunks +10 lines, -10 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
7 years, 1 month ago (2013-11-15 03:32:37 UTC) #1
eseidel
lgtm https://codereview.chromium.org/65043011/diff/1/Source/core/dom/DOMImplementation.cpp File Source/core/dom/DOMImplementation.cpp (right): https://codereview.chromium.org/65043011/diff/1/Source/core/dom/DOMImplementation.cpp#newcode188 Source/core/dom/DOMImplementation.cpp:188: return DocumentType::create(&m_document, qualifiedName, publicId, systemId); I don't thnik ...
7 years, 1 month ago (2013-11-15 08:53:03 UTC) #2
Inactive
https://codereview.chromium.org/65043011/diff/1/Source/core/dom/DOMImplementation.cpp File Source/core/dom/DOMImplementation.cpp (right): https://codereview.chromium.org/65043011/diff/1/Source/core/dom/DOMImplementation.cpp#newcode188 Source/core/dom/DOMImplementation.cpp:188: return DocumentType::create(&m_document, qualifiedName, publicId, systemId); On 2013/11/15 08:53:03, eseidel ...
7 years, 1 month ago (2013-11-15 13:16:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/65043011/100001
7 years, 1 month ago (2013-11-15 16:29:45 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-15 18:36:19 UTC) #5
Message was sent while issue was closed.
Change committed as 162126

Powered by Google App Engine
This is Rietveld 408576698