Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 650423005: Prohibit serializing with --harmony-scoping. (Closed)

Created:
6 years, 2 months ago by Yang
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Prohibit serializing with --harmony-scoping. R=jochen@chromium.org BUG=v8:3628 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=24686

Patch Set 1 #

Patch Set 2 : do not crash when --harmony is on #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -1 line) Patch
M src/compiler.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/cctest.status View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 2 months ago (2014-10-15 12:57:01 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-15 14:19:46 UTC) #2
Yang
6 years, 2 months ago (2014-10-17 09:54:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24686 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698