Moving Passwordmanager::RegisterLocalPref() to components.

Moving Passwordmanager::RegisterLocalPref() to components.

PasswordManager::RegisterLocalPrefs(PrefRegistrySimple*) is declared in
components/password_manager/core/browser/password_manager.h,
but only defined in chrome/browser/password_manager/password_manager_util_win.cc.
That's confusing, all of PasswordManager should be defined in
components/password_manager/core/browser/password_manager.cc.

This patch move the definition of RegisterLocalPrefs(PrefRegistrySimple*)
from password_manager_util_win.cc to password_manager.cc.

BUG=361529
Committed: https://crrev.com/b50f2e197843673d86460e92a377c7d037cbaa22
Cr-Commit-Position: refs/heads/master@{#299849}

[Jitu( very slow this week), 2014-10-15 13:52:18]

jitendra.ks@samsung.com changed reviewers:
+ vabr@chromium.org

[Jitu( very slow this week), 2014-10-15 13:52:19]

PTAL

[vabr (Chromium), 2014-10-15 15:10:47]

LGTM, but please do not land before addressing the following three comments:

(1) Add a BUG= reference in the CL description. That is necessary for linking
the CL to the bug.

(2) Please correct the CL description: I made a mistake when creating the issue
description, which you copied this from. I corrected my mistake in
http://crbug.com/361529#c5, please adjust the description of this CL
accordingly.

(3) (see the code comment below)

Cheers,
Vaclav

https://codereview.chromium.org/650423004/diff/20001/components/password_mana...
File components/password_manager/core/browser/password_manager.cc (right):

https://codereview.chromium.org/650423004/diff/20001/components/password_mana...
components/password_manager/core/browser/password_manager.cc:113: void
PasswordManager::RegisterLocalPrefs(PrefRegistrySimple* registry) {
nit: Put the following line above the current one:
// static

[vabr (Chromium), 2014-10-15 15:11:28]

On 2014/10/15 15:10:47, vabr (Chromium) wrote:
> LGTM, but please do not land before addressing the following three comments:
> 
> (1) Add a BUG= reference in the CL description. That is necessary for linking
> the CL to the bug.

And by that I mean, add the following line at the end of the description:
BUG=361529

[Jitu( very slow this week), 2014-10-16 04:14:12]

https://codereview.chromium.org/650423004/diff/20001/components/password_mana...
File components/password_manager/core/browser/password_manager.cc (right):

https://codereview.chromium.org/650423004/diff/20001/components/password_mana...
components/password_manager/core/browser/password_manager.cc:113: void
PasswordManager::RegisterLocalPrefs(PrefRegistrySimple* registry) {
On 2014/10/15 15:10:46, vabr (Chromium) wrote:
> nit: Put the following line above the current one:
> // static

Done.

[Jitu( very slow this week), 2014-10-16 04:15:23]

On 2014/10/16 04:14:12, (slow this week) wrote:
>
https://codereview.chromium.org/650423004/diff/20001/components/password_mana...
> File components/password_manager/core/browser/password_manager.cc (right):
> 
>
https://codereview.chromium.org/650423004/diff/20001/components/password_mana...
> components/password_manager/core/browser/password_manager.cc:113: void
> PasswordManager::RegisterLocalPrefs(PrefRegistrySimple* registry) {
> On 2014/10/15 15:10:46, vabr (Chromium) wrote:
> > nit: Put the following line above the current one:
> > // static
> 
> Done.

Addressed all 3 comments.

Thanks

[Jitu( very slow this week), 2014-10-16 04:15:34]

The CQ bit was checked by jitendra.ks@samsung.com

[commit-bot: I haz the power, 2014-10-16 04:16:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/650423004/40001

[commit-bot: I haz the power, 2014-10-16 05:12:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-16 05:12:50]

Patchset 3 (id:??) landed as
https://crrev.com/b50f2e197843673d86460e92a377c7d037cbaa22
Cr-Commit-Position: refs/heads/master@{#299849}