base/mac/foundation_util_unittest.mm - Issue 650393002: Modify ALLOW_UNUSED to allow enabling unused local warnings on MSVC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/mac/foundation_util_unittest.mm

Issue 650393002: Modify ALLOW_UNUSED to allow enabling unused local warnings on MSVC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert review comment Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/mac/foundation_util_unittest.mm

diff --git a/base/mac/foundation_util_unittest.mm b/base/mac/foundation_util_unittest.mm

index 916a13bd7faa3e98a15ff60614f6cdd64e764043..e60a0f6b6495c6cbe04331f741c15ff3c07b4496 100644

--- a/base/mac/foundation_util_unittest.mm

+++ b/base/mac/foundation_util_unittest.mm

@@ -331,12 +331,12 @@ TEST(StringNumberConversionsTest, FormatNSInteger) {

#endif // defined(ARCH_CPU_64_BITS)

NSInteger some_nsinteger;

- FormatNSIntegerAsType* pointer_to_some_nsinteger ALLOW_UNUSED =

- &some_nsinteger;

+ FormatNSIntegerAsType* pointer_to_some_nsinteger = &some_nsinteger;

+ ALLOW_UNUSED_LOCAL(pointer_to_some_nsinteger);

NSUInteger some_nsuinteger;

- FormatNSUIntegerAsType* pointer_to_some_nsuinteger ALLOW_UNUSED =

- &some_nsuinteger;

+ FormatNSUIntegerAsType* pointer_to_some_nsuinteger = &some_nsuinteger;

+ ALLOW_UNUSED_LOCAL(pointer_to_some_nsuinteger);

// Check that format specifier works correctly for NSInteger.

const struct {

« base/compiler_specific.h ('K') | « base/logging_unittest.cc ('k') | base/tuple_unittest.cc » ('j') | no next file with comments »