Modify ALLOW_UNUSED to allow enabling unused local warnings on MSVC.

base/compiler_specific.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_COMPILER_SPECIFIC_H_
 #define BASE_COMPILER_SPECIFIC_H_
 
 #include "build/build_config.h"
 
 #if defined(COMPILER_MSVC)
@@ skipping 76 matching lines @@
 #if defined(COMPILER_MSVC)
 #define STATIC_CONST_MEMBER_DEFINITION __declspec(selectany)
 #else
 #define STATIC_CONST_MEMBER_DEFINITION
 #endif
 
 // Annotate a variable indicating it's ok if the variable is not used.
 // (Typically used to silence a compiler warning when the assignment
 // is important for some other reason.)
 // Use like:
-//   int x ALLOW_UNUSED = ...;
+//   int x = ...;
+//   ALLOW_UNUSED_LOCAL(x);
+#define ALLOW_UNUSED_LOCAL(x) false ? (void)x : (void)0

[Nico, 2014/10/25 22:56:08]

How is this different from ignore_result()?

Why not just (void)x, why the `false?:`?

[Peter Kasting, 2014/10/27 17:58:44]

It doesn't implicitly take the address of |x| or in any other way evaluate it
(see below).

It would also be strange for code to write "ignore_result(x)" as a way of
marking |x| as "allowed to be unused" -- that could be very confusing to a
reader depending on the situation.
This references |x| without any possibility of actually evaluating it, just in
case evaluating the argument has some effect (e.g. x is declared volatile and so
we generate a load the compiler can't optimize away, or I suppose maybe this
gets used inside another macro and |x| turns out to be some expression with side
effects).

I think it's unlikely the distinction actually matters, but this form is at
least as safe as the other, so I don't see anything wrong with using it.

+
+// Annotate a typedef or function indicating it's ok if it's not used.
+// Use like:
+//   typedef Foo Bar ALLOW_UNUSED_TYPE;
 #if defined(COMPILER_GCC)
-#define ALLOW_UNUSED __attribute__((unused))
+#define ALLOW_UNUSED_TYPE __attribute__((unused))
 #else
-#define ALLOW_UNUSED
+#define ALLOW_UNUSED_TYPE
 #endif
 
 // Annotate a function indicating it should not be inlined.
 // Use like:
 //   NOINLINE void DoStuff() { ... }
 #if defined(COMPILER_GCC)
 #define NOINLINE __attribute__((noinline))
 #elif defined(COMPILER_MSVC)
 #define NOINLINE __declspec(noinline)
 #else
@@ skipping 80 matching lines @@
 // Macro for hinting that an expression is likely to be false.
 #if !defined(UNLIKELY)
 #if defined(COMPILER_GCC)
 #define UNLIKELY(x) __builtin_expect(!!(x), 0)
 #else
 #define UNLIKELY(x) (x)
 #endif  // defined(COMPILER_GCC)
 #endif  // !defined(UNLIKELY)
 
 #endif  // BASE_COMPILER_SPECIFIC_H_