Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 650353003: Don't clobber active page scale animation with null pointer. (Closed)

Created:
6 years, 2 months ago by aelias_OOO_until_Jul13
Modified:
6 years, 2 months ago
Reviewers:
bokan
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't clobber active page scale animation with null pointer. r297913 introduced the bug that if another activation happens during a page scale animation, it's clobbered by a null pointer. Only copy into LTHI::page_scale_animation_ when the LTI has an instance of it. NOTRY=true BUG=419450 Committed: https://crrev.com/74c39357ba160b985378a5867fac496ea49f23ad Cr-Commit-Position: refs/heads/master@{#299421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aelias_OOO_until_Jul13
Hi bokan@, PTAL.
6 years, 2 months ago (2014-10-14 00:32:49 UTC) #2
bokan
lgtm, thanks for tracking these down.
6 years, 2 months ago (2014-10-14 02:12:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650353003/1
6 years, 2 months ago (2014-10-14 03:45:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 03:48:22 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 03:49:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74c39357ba160b985378a5867fac496ea49f23ad
Cr-Commit-Position: refs/heads/master@{#299421}

Powered by Google App Engine
This is Rietveld 408576698