Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 650343004: Add comment on StyleInvalidator trace events (Closed)

Created:
6 years, 2 months ago by kouhei (in TOK)
Modified:
6 years, 2 months ago
Reviewers:
haraken, pdr.
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add comment on StyleInvalidator trace events Warn that StyleInvalidator methods are performance sensitive and add notes about its implementation. TBR=pdr,haraken NOTRY=true only comment additions. confirmed compile pass. BUG=410701 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M Source/core/css/invalidation/StyleInvalidator.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kouhei (in TOK)
6 years, 2 months ago (2014-10-20 04:42:06 UTC) #1
haraken
LGTM
6 years, 2 months ago (2014-10-20 04:47:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650343004/1
6 years, 2 months ago (2014-10-20 04:50:11 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 04:51:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183961

Powered by Google App Engine
This is Rietveld 408576698