Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 650333003: Remove deprecated class WebContentsObserverAndroid and cleanup existing usages. (Closed)

Created:
6 years, 2 months ago by wajahat
Modified:
6 years, 2 months ago
Reviewers:
nyquist, Yaron
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated class WebContentsObserverAndroid and cleanup existing usages. In continuation of the CL https://codereview.chromium.org/589113002/ this CL removes deprecated class WebContentsObserverAndroid and cleans up existing usage of this class where ever it is occured. This patch will be landed when external repositories has renamed WebContentsObserverAndroid to WebContentsObserver BUG=396118 Committed: https://crrev.com/1365c44bfc346304ccd36db4aac058b439420b70 Cr-Commit-Position: refs/heads/master@{#300426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -22 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopupLegacy.java View 2 chunks +3 lines, -3 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
wajahat
PTAL, Thanks!
6 years, 2 months ago (2014-10-20 12:39:01 UTC) #2
Yaron
lgtm
6 years, 2 months ago (2014-10-20 18:11:55 UTC) #3
nyquist
lgtm
6 years, 2 months ago (2014-10-20 22:24:05 UTC) #4
nyquist
The external dependencies of this CL has landed.
6 years, 2 months ago (2014-10-20 22:25:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650333003/1
6 years, 2 months ago (2014-10-21 05:33:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 06:15:27 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 06:16:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1365c44bfc346304ccd36db4aac058b439420b70
Cr-Commit-Position: refs/heads/master@{#300426}

Powered by Google App Engine
This is Rietveld 408576698