Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 650303002: Add ExceptionSnapshotMac (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -0 lines) Patch
A snapshot/exception_snapshot_mac.h View 1 chunk +91 lines, -0 lines 0 comments Download
A snapshot/exception_snapshot_mac.cc View 1 1 chunk +175 lines, -0 lines 0 comments Download
M snapshot/snapshot.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
This doesn’t have its own test because of bug 2. This just wraps existing well-tested ...
6 years, 2 months ago (2014-10-13 19:10:49 UTC) #2
Robert Sesek
https://codereview.chromium.org/650303002/diff/1/snapshot/exception_snapshot_mac.cc File snapshot/exception_snapshot_mac.cc (right): https://codereview.chromium.org/650303002/diff/1/snapshot/exception_snapshot_mac.cc#newcode70 snapshot/exception_snapshot_mac.cc:70: exception_type_t original_exception = (code[0] >> 20) & 0xf; This ...
6 years, 2 months ago (2014-10-13 21:04:55 UTC) #3
Mark Mentovai
Yup, that’s right. Updated.
6 years, 2 months ago (2014-10-13 21:32:50 UTC) #4
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-13 21:44:05 UTC) #5
Mark Mentovai
6 years, 2 months ago (2014-10-13 22:09:11 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:90001) manually as
d7eb23c93e90072a464438955c1a06c32b4d02c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698