Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 650293007: Refactor top_25 so only page class with custom Run.. logic is defined (Closed)

Created:
6 years, 1 month ago by nednguyen
Modified:
6 years, 1 month ago
Reviewers:
dtu, ernstm, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactor top_25 so only page class with custom Run.. logic is defined BUG=418375 Committed: https://crrev.com/26757de92c2d126c705d35056119418d1d03895a Cr-Commit-Position: refs/heads/master@{#301487}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix style nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -117 lines) Patch
M tools/perf/page_sets/top_25.py View 1 15 chunks +81 lines, -117 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nednguyen
6 years, 1 month ago (2014-10-24 23:24:02 UTC) #2
ernstm
LGTM % nit https://codereview.chromium.org/650293007/diff/1/tools/perf/page_sets/top_25.py File tools/perf/page_sets/top_25.py (right): https://codereview.chromium.org/650293007/diff/1/tools/perf/page_sets/top_25.py#newcode330 tools/perf/page_sets/top_25.py:330: 'http://www.linkedin.com/in/linustorvalds', self, 'LinkedIn')) to be consistent ...
6 years, 1 month ago (2014-10-27 21:30:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650293007/20001
6 years, 1 month ago (2014-10-27 21:52:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 23:43:43 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 23:45:07 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26757de92c2d126c705d35056119418d1d03895a
Cr-Commit-Position: refs/heads/master@{#301487}

Powered by Google App Engine
This is Rietveld 408576698