Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 650293006: Tidy ELF section rewriting internal interface. (Closed)

Created:
6 years, 2 months ago by simonb (inactive)
Modified:
6 years, 1 month ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Tidy ELF section rewriting internal interface. Change section data rewriter internal interface to take a section directly, rather than a pointer to section data. Remove some of the more confusing instances of data pointers being passed between pack and unpack functions. Readability only. No behavioural effects. BUG=385553 Committed: https://crrev.com/1203993ae31ae13a96b935ed3638afe378095576 Cr-Commit-Position: refs/heads/master@{#301347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M tools/relocation_packer/src/elf_file.h View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/relocation_packer/src/elf_file.cc View 13 chunks +18 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
simonb (inactive)
6 years, 2 months ago (2014-10-24 17:36:03 UTC) #2
rmcilroy
lgtm, thanks.
6 years, 1 month ago (2014-10-27 10:39:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650293006/1
6 years, 1 month ago (2014-10-27 11:28:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 12:12:24 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 12:12:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1203993ae31ae13a96b935ed3638afe378095576
Cr-Commit-Position: refs/heads/master@{#301347}

Powered by Google App Engine
This is Rietveld 408576698