Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 650263002: add pictures to lua (Closed)

Created:
6 years, 2 months ago by reed1
Modified:
6 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -21 lines) Patch
M resources/slides.lua View 4 chunks +37 lines, -20 lines 0 comments Download
M src/utils/SkLua.cpp View 9 chunks +107 lines, -1 line 3 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650263002/1
6 years, 2 months ago (2014-10-13 17:52:10 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-13 17:52:11 UTC) #4
robertphillips
lgtm w/ question about width & height return values. https://codereview.chromium.org/650263002/diff/1/src/utils/SkLua.cpp File src/utils/SkLua.cpp (right): https://codereview.chromium.org/650263002/diff/1/src/utils/SkLua.cpp#newcode1571 src/utils/SkLua.cpp:1571: ...
6 years, 2 months ago (2014-10-13 18:31:59 UTC) #5
reed1
https://codereview.chromium.org/650263002/diff/1/src/utils/SkLua.cpp File src/utils/SkLua.cpp (right): https://codereview.chromium.org/650263002/diff/1/src/utils/SkLua.cpp#newcode1571 src/utils/SkLua.cpp:1571: On 2014/10/13 18:31:59, robertphillips wrote: > float ? the ...
6 years, 2 months ago (2014-10-13 18:34:37 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 19:38:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 96affcde22a675e3629b9da490bb45a0ab07fa2b

Powered by Google App Engine
This is Rietveld 408576698