Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: golden/go/db/db.go

Issue 650253003: Added HTTP endpoints for Correctness counts (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Addressed Comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: golden/go/db/db.go
diff --git a/golden/go/db/db.go b/golden/go/db/db.go
index 9f2f448342cbb1b90e0df8aaf43fd19e227daec5..aeb1d9e26a27c8ccb26fbb0d36ae05fe06e27989 100644
--- a/golden/go/db/db.go
+++ b/golden/go/db/db.go
@@ -18,12 +18,11 @@ func MigrationSteps() []database.MigrationStep {
return migrationSteps
}
-// Returns the DB connection string for running in production where a
-// metadata server is available. If 'local' is true it will always return
-// "" (empty string). When used with Init() this will cause it to use a
-// local SQLite database. If it's not local and the meta data server is
-// unreachable it will terminate.
-func GetDatabase(mySQLConnStr string, sqlitePath string, local bool) *database.DatabaseConfig {
+// Returns DatabaseConfig instance for running in production if a
+// metadata server is available. If 'local' is true it will always
+// set the MySQL connection string to "" and thus use a local SQLite database
+// when used with database.NewVersionedDB.
+func GetDatabaseConfig(mySQLConnStr string, sqlitePath string, local bool) *database.DatabaseConfig {
useMySQLConnStr := mySQLConnStr
// We are in the production environment, so we look up the password.

Powered by Google App Engine
This is Rietveld 408576698