Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 650253002: [Telemetry] Remove logic that handles case test=None in page_runner.py (Closed)

Created:
6 years, 2 months ago by nednguyen
Modified:
6 years, 2 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove logic that handles case test=None in page_runner.py Clearly these are not needed since test cannot be None. If it's None, page_runner.py would crash on line 473. This patch also renames PageState to _PageState to restrict access to this outside of page_runner.py BUG=418278 Committed: https://crrev.com/e9e51e6eb800cc4638441601ef75fd2e69935956 Cr-Commit-Position: refs/heads/master@{#299340}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Fix stray diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M tools/telemetry/telemetry/page/page_runner.py View 1 4 chunks +9 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nednguyen
6 years, 2 months ago (2014-10-13 17:47:44 UTC) #3
tonyg
lgtm % nit https://codereview.chromium.org/650253002/diff/30001/tools/telemetry/telemetry/page/page_runner.py File tools/telemetry/telemetry/page/page_runner.py (right): https://codereview.chromium.org/650253002/diff/30001/tools/telemetry/telemetry/page/page_runner.py#newcode2 tools/telemetry/telemetry/page/page_runner.py:2: # Use of this source code ...
6 years, 2 months ago (2014-10-13 18:07:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650253002/180001
6 years, 2 months ago (2014-10-13 18:22:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:180001)
6 years, 2 months ago (2014-10-13 19:21:24 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 19:22:15 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e9e51e6eb800cc4638441601ef75fd2e69935956
Cr-Commit-Position: refs/heads/master@{#299340}

Powered by Google App Engine
This is Rietveld 408576698