Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 650223002: Revert "Removes MediaDecoderJob virtual method call from destructor." (Closed)

Created:
6 years, 2 months ago by gunsch
Modified:
6 years, 2 months ago
Reviewers:
qinmin, ycheo (away)
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Removes MediaDecoderJob virtual method call from destructor." This reverts commit 6a1f7b511cdcb590bcebb8371e880908fe592a22. The above commit was only intended for cherry-picking to M37/M38 branches. R=qinmin@chromium.org,ycheo@chromium.org BUG= Committed: https://crrev.com/69b99efe022a4e44384522da1c117364e9d1dc4d Cr-Commit-Position: refs/heads/master@{#299312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M media/base/android/media_decoder_job.cc View 3 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
gunsch
6 years, 2 months ago (2014-10-13 16:06:50 UTC) #1
qinmin
lgtm
6 years, 2 months ago (2014-10-13 16:19:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650223002/1
6 years, 2 months ago (2014-10-13 16:23:19 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/62579)
6 years, 2 months ago (2014-10-13 16:55:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650223002/1
6 years, 2 months ago (2014-10-13 16:59:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 17:15:10 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 17:15:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69b99efe022a4e44384522da1c117364e9d1dc4d
Cr-Commit-Position: refs/heads/master@{#299312}

Powered by Google App Engine
This is Rietveld 408576698