Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 650203003: Revert of Catch uncaught promise rejections from V8 and log to console. (Closed)

Created:
6 years, 2 months ago by cbiesinger
Modified:
6 years, 2 months ago
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, rwlbuis
Project:
blink
Visibility:
Public.

Description

Revert of Catch uncaught promise rejections from V8 and log to console. (patchset #13 id:520001 of https://codereview.chromium.org/625943002/) Reason for revert: This is likely the cause of breakage for these browser_tests: ManageProfileUITest.Create_NameUpdateOnAvatarSelected ManageProfileUITest.Create_NoNameUpdateOnAvatarSelectedAfterRevert ManageProfileUITest.Create_NoNameUpdateOnAvatarSelectedAfterEdit https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/builds/56670 Original issue's description: > Catch uncaught promise rejections from V8 and log to console. > > Print error messages to DevTools console for rejected Promises that are unhandled by the platform end-of-turn. > > BUG=393913 > R=pfeldman, yurys > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183464 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183598 TBR=pfeldman@chromium.org,yurys@chromium.org,jl@opera.com,aandrey@chromium.org NOTREECHECKS=true NOTRY=true BUG=393913 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -301 lines) Patch
M LayoutTests/fast/css/fontfaceset-multiple-faces-download-error.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-multiple-families.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/console-test.js View 4 chunks +8 lines, -22 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/test-helpers.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-format-es6.html View 1 chunk +1 line, -4 lines 0 comments Download
D LayoutTests/inspector/console/console-uncaught-promise.html View 1 chunk +0 lines, -72 lines 0 comments Download
D LayoutTests/inspector/console/console-uncaught-promise-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/inspector/sources/debugger/debugger-uncaught-promise-on-pause.html View 1 chunk +0 lines, -83 lines 0 comments Download
D LayoutTests/inspector/sources/debugger/debugger-uncaught-promise-on-pause-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/event-listener-breakpoints-promises.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8Initializer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/V8Initializer.cpp View 4 chunks +0 lines, -76 lines 0 comments Download
M Source/web/WebKit.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
cbiesinger
Created Revert of Catch uncaught promise rejections from V8 and log to console.
6 years, 2 months ago (2014-10-13 16:17:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650203003/1
6 years, 2 months ago (2014-10-13 16:18:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 183611
6 years, 2 months ago (2014-10-13 16:19:17 UTC) #3
aandrey
6 years, 2 months ago (2014-10-13 19:28:40 UTC) #5
Message was sent while issue was closed.
Seems like the problem is in the tests, as there should not be unhandled promise
rejections (as well as uncaught exceptions). The reverted patch just uncovered
the problem.

Powered by Google App Engine
This is Rietveld 408576698