Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 650193003: [ServiceWorker] Add test for the hanging bug in loading ServiceWorker script. (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
Reviewers:
michaeln
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Add test for the hanging bug in loading ServiceWorker script. Chromium side fix patch: https://codereview.chromium.org/640923003 BUG=419999 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183971

Patch Set 1 #

Total comments: 2

Patch Set 2 : change timeout to 10000 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
A LayoutTests/http/tests/serviceworker/chromium/load-flushed-script.html View 1 1 chunk +21 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/serviceworker/chromium/resources/load-flushed-script.php View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
horo
michaeln@ Could you please review this?
6 years, 2 months ago (2014-10-16 07:53:25 UTC) #2
michaeln
lgtm https://codereview.chromium.org/650193003/diff/1/LayoutTests/http/tests/serviceworker/chromium/load-flushed-script.html File LayoutTests/http/tests/serviceworker/chromium/load-flushed-script.html (right): https://codereview.chromium.org/650193003/diff/1/LayoutTests/http/tests/serviceworker/chromium/load-flushed-script.html#newcode20 LayoutTests/http/tests/serviceworker/chromium/load-flushed-script.html:20: {timeout: 2000}); might want to increase the timeout ...
6 years, 2 months ago (2014-10-17 21:22:01 UTC) #3
horo
https://codereview.chromium.org/650193003/diff/1/LayoutTests/http/tests/serviceworker/chromium/load-flushed-script.html File LayoutTests/http/tests/serviceworker/chromium/load-flushed-script.html (right): https://codereview.chromium.org/650193003/diff/1/LayoutTests/http/tests/serviceworker/chromium/load-flushed-script.html#newcode20 LayoutTests/http/tests/serviceworker/chromium/load-flushed-script.html:20: {timeout: 2000}); On 2014/10/17 21:22:01, michaeln wrote: > might ...
6 years, 2 months ago (2014-10-20 03:01:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650193003/20001
6 years, 2 months ago (2014-10-20 10:06:07 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 11:14:32 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183971

Powered by Google App Engine
This is Rietveld 408576698