Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 650183003: Clean up forward declarations in Source/core/inspector (Closed)

Created:
6 years, 2 months ago by rwlbuis
Modified:
6 years, 2 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations in Source/core/inspector Clean up forward declarations in Source/core/inspector These forward references are not needed anymore. After this patch, Source/core/inspector has no unneeded forward references any more. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183665

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -75 lines) Patch
M Source/core/inspector/BindingVisitors.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InjectedScript.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptHost.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorCanvasAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/inspector/InspectorController.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDOMStorageAgent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorHeapProfilerAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorInspectorAgent.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorMemoryAgent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.h View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorRuntimeAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorStyleSheet.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.h View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorWorkerAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/PageDebuggerAgent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/TimelineRecordFactory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/WorkerDebuggerAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/WorkerInspectorController.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
rwlbuis
PTAL, simple cleanup patch.
6 years, 2 months ago (2014-10-13 17:09:43 UTC) #2
vsevik
lgtm
6 years, 2 months ago (2014-10-13 18:16:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650183003/1
6 years, 2 months ago (2014-10-13 18:17:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31550)
6 years, 2 months ago (2014-10-13 20:18:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650183003/1
6 years, 2 months ago (2014-10-13 21:26:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31579)
6 years, 2 months ago (2014-10-14 00:10:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650183003/1
6 years, 2 months ago (2014-10-14 11:25:48 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 12:11:53 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183665

Powered by Google App Engine
This is Rietveld 408576698