Make V4L2VEA GetSupportedProfiles static.

Make V4L2VEA GetSupportedProfiles static.

VEA supported profiles are added to GPUInfo when GPU
process starts. But the video devices are not ready
yet at that time. We need a low risk way to fix this
in M39. Make V4L2VEA GetSupportedProfiles static so we
can merge it back to M39. This will be fixed later in
a proper way.

BUG=418762
TEST=Reboot on peach pit and run apprtc loopback.

Committed: https://crrev.com/8396651c1a54e3e17559ca93140560555dc2e905
Cr-Commit-Position: refs/heads/master@{#299453}

[wuchengli, 2014-10-13 15:16:25]

wuchengli@chromium.org changed reviewers:
+ kcwu@chromium.org, posciak@chromium.org

[wuchengli, 2014-10-13 15:16:26]

PTAL

[Pawel Osciak, 2014-10-13 20:17:48]

lgtm % nit

https://codereview.chromium.org/650183002/diff/1/content/common/gpu/media/v4l...
File content/common/gpu/media/v4l2_video_encode_accelerator.cc (right):

https://codereview.chromium.org/650183002/diff/1/content/common/gpu/media/v4l...
content/common/gpu/media/v4l2_video_encode_accelerator.cc:285: return
GetSupportedProfilesStatic();
Are their any users of this? I think we should have NOTIMPLEMENTED() here
instead?

[kcwu, 2014-10-14 00:56:59]

lgtm

https://codereview.chromium.org/650183002/diff/1/content/common/gpu/media/gpu...
File content/common/gpu/media/gpu_video_encode_accelerator.cc (right):

https://codereview.chromium.org/650183002/diff/1/content/common/gpu/media/gpu...
content/common/gpu/media/gpu_video_encode_accelerator.cc:171: //
TODO(wuchengli): remove this.
Please describe the remove condition (or bug id) here.

[wuchengli, 2014-10-14 02:07:43]

piman@ thought increasing the boot time was better than making
GetSupportedProfiles a sync IPC. Let's hold this until we reach a consensus on
the bug.

https://codereview.chromium.org/650183002/diff/1/content/common/gpu/media/v4l...
File content/common/gpu/media/v4l2_video_encode_accelerator.cc (right):

https://codereview.chromium.org/650183002/diff/1/content/common/gpu/media/v4l...
content/common/gpu/media/v4l2_video_encode_accelerator.cc:285: return
GetSupportedProfilesStatic();
On 2014/10/13 20:17:48, Pawel Osciak wrote:
> Are their any users of this? I think we should have NOTIMPLEMENTED() here
> instead?
There are no uesrs. But this is "not used", not NOTIMPLEMENTED.

[Pawel Osciak, 2014-10-14 07:04:20]

https://codereview.chromium.org/650183002/diff/1/content/common/gpu/media/v4l...
File content/common/gpu/media/v4l2_video_encode_accelerator.cc (right):

https://codereview.chromium.org/650183002/diff/1/content/common/gpu/media/v4l...
content/common/gpu/media/v4l2_video_encode_accelerator.cc:285: return
GetSupportedProfilesStatic();
On 2014/10/14 02:07:43, wuchengli wrote:
> On 2014/10/13 20:17:48, Pawel Osciak wrote:
> > Are their any users of this? I think we should have NOTIMPLEMENTED() here
> > instead?
> There are no uesrs. But this is "not used", not NOTIMPLEMENTED.

Right, I was just looking for something that would be visible in case someone
used it later by accident or we missed something, iirc NOTREACHED is only a
debug check while NOTIMPLEMENTED is a LOG(ERROR).
In any case, I don't have issues with this, so ok.

[wuchengli, 2014-10-14 08:48:47]

https://codereview.chromium.org/650183002/diff/1/content/common/gpu/media/gpu...
File content/common/gpu/media/gpu_video_encode_accelerator.cc (right):

https://codereview.chromium.org/650183002/diff/1/content/common/gpu/media/gpu...
content/common/gpu/media/gpu_video_encode_accelerator.cc:171: //
TODO(wuchengli): remove this.
On 2014/10/14 00:56:58, kcwu wrote:
> Please describe the remove condition (or bug id) here.

Done.

[wuchengli, 2014-10-14 09:00:05]

The CQ bit was checked by wuchengli@chromium.org

[commit-bot: I haz the power, 2014-10-14 09:00:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/650183002/80001

[commit-bot: I haz the power, 2014-10-14 09:51:12]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2014-10-14 09:52:01]

Patchset 2 (id:??) landed as
https://crrev.com/8396651c1a54e3e17559ca93140560555dc2e905
Cr-Commit-Position: refs/heads/master@{#299453}