Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 650143002: Add flag to enable antialiased clipping in HTML5 canvas (Closed)

Created:
6 years, 2 months ago by robertphillips
Modified:
6 years, 2 months ago
CC:
bsalomon_chromium, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, Justin Novosad, mkwst+moarreviews-renderer_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add flag to enable antialiased clipping in HTML5 canvas Here is the OWP tracking bug: https://code.google.com/p/chromium/issues/detail?id=422984 Here is the link to the entry on the feature dashboard: https://www.chromestatus.com/features/4871530282483712 Currently canvas clips are not antialiased which differs what what other browsers are doing and what the users expect. This CL starts surfacing the desired antialiased clipping behavior behind a flag so developers can start assessing the capability. This needs to land after the Blink CL: Plumb in flag to enable antialiased clipping in HTML 5 Canvas - https://codereview.chromium.org/652483003/ BUG=crbug.com/424291 BUG=crbug.com/422984 Committed: https://crrev.com/e25137bd1b720b121f4c365e08e9e18bb2cb9aab Cr-Commit-Position: refs/heads/master@{#300261}

Patch Set 1 #

Patch Set 2 : clean up #

Total comments: 4

Patch Set 3 : Address code review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
robertphillips
6 years, 2 months ago (2014-10-13 15:19:49 UTC) #4
jochen (gone - plz use gerrit)
lgtm with nit you'll need a security review https://codereview.chromium.org/650143002/diff/90001/content/public/common/content_switches.h File content/public/common/content_switches.h (right): https://codereview.chromium.org/650143002/diff/90001/content/public/common/content_switches.h#newcode92 content/public/common/content_switches.h:92: CONTENT_EXPORT ...
6 years, 2 months ago (2014-10-14 13:50:12 UTC) #5
Justin Novosad
https://codereview.chromium.org/650143002/diff/90001/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/650143002/diff/90001/content/public/common/content_switches.cc#newcode282 content/public/common/content_switches.cc:282: const char kEnable2dCanvasClipAntialiasing[] = "enable-canvas-clip-aa"; Nit: command line flags ...
6 years, 2 months ago (2014-10-14 14:21:50 UTC) #7
robertphillips
https://codereview.chromium.org/650143002/diff/90001/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/650143002/diff/90001/content/public/common/content_switches.cc#newcode282 content/public/common/content_switches.cc:282: const char kEnable2dCanvasClipAntialiasing[] = "enable-canvas-clip-aa"; On 2014/10/14 14:21:50, junov ...
6 years, 2 months ago (2014-10-16 13:33:23 UTC) #8
Tom Sepez
Messages LGTM.
6 years, 2 months ago (2014-10-16 16:34:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650143002/150001
6 years, 2 months ago (2014-10-20 12:24:56 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:150001)
6 years, 2 months ago (2014-10-20 13:44:43 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 13:45:29 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e25137bd1b720b121f4c365e08e9e18bb2cb9aab
Cr-Commit-Position: refs/heads/master@{#300261}

Powered by Google App Engine
This is Rietveld 408576698