Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 650126: Send AfterCompile event from in debugger (Closed)

Created:
10 years, 10 months ago by Peter Rybin
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Send AfterCompile event from in debugger

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -1 line 2 comments Download
M src/debug.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/debug.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Rybin
Hi Soren I need to send AfterCompile event when patching a script. However, the new ...
10 years, 10 months ago (2010-02-22 02:00:36 UTC) #1
Søren Thygesen Gjesse
http://codereview.chromium.org/650126/diff/4/5 File src/compiler.cc (right): http://codereview.chromium.org/650126/diff/4/5#newcode227 src/compiler.cc:227: Debugger::OnAfterCompile(script, fun, false); It looks as if this is ...
10 years, 10 months ago (2010-02-22 10:41:20 UTC) #2
Peter Rybin
10 years, 10 months ago (2010-02-22 21:19:03 UTC) #3
http://codereview.chromium.org/650126/diff/4/5
File src/compiler.cc (right):

http://codereview.chromium.org/650126/diff/4/5#newcode227
src/compiler.cc:227: Debugger::OnAfterCompile(script, fun, false);
On 2010/02/22 10:41:20, Søren Gjesse wrote:
> It looks as if this is the only place this function is called, so I don't see
> why the extra argument is needed.

That's right. The actual usage is in one of my next CLs. This way I am trying to
split one huge change into a smaller separately-compilable pieces.

However I'm fine with merging this CL with the one that actually uses the 3rd
argument.

Powered by Google App Engine
This is Rietveld 408576698