Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 650123002: DevTools: [SSP] fix live edit of property values (Closed)

Created:
6 years, 2 months ago by lushnikov
Modified:
6 years, 2 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: [SSP] fix live edit of property values The problem arises due to the fact that treeElement value is not updated at the moment of keyDown/keyPress events. The "input" event should be handled for the proper text value. BUG=422928 R=apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183612

Patch Set 1 #

Patch Set 2 : update test description #

Total comments: 4

Patch Set 3 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -9 lines) Patch
A LayoutTests/inspector/elements/styles/edit-value-inside-property.html View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
A LayoutTests/inspector/elements/styles/edit-value-inside-property-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 8 chunks +32 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
lushnikov
please take a look
6 years, 2 months ago (2014-10-13 13:13:49 UTC) #1
apavlov
lgtm https://codereview.chromium.org/650123002/diff/50001/LayoutTests/inspector/elements/styles/edit-value-inside-property.html File LayoutTests/inspector/elements/styles/edit-value-inside-property.html (right): https://codereview.chromium.org/650123002/diff/50001/LayoutTests/inspector/elements/styles/edit-value-inside-property.html#newcode40 LayoutTests/inspector/elements/styles/edit-value-inside-property.html:40: InspectorTest.addResult("ERROR: Failed to match styles."). "Failed to get ...
6 years, 2 months ago (2014-10-13 13:39:49 UTC) #2
lushnikov
https://codereview.chromium.org/650123002/diff/50001/LayoutTests/inspector/elements/styles/edit-value-inside-property.html File LayoutTests/inspector/elements/styles/edit-value-inside-property.html (right): https://codereview.chromium.org/650123002/diff/50001/LayoutTests/inspector/elements/styles/edit-value-inside-property.html#newcode40 LayoutTests/inspector/elements/styles/edit-value-inside-property.html:40: InspectorTest.addResult("ERROR: Failed to match styles."). On 2014/10/13 13:39:48, apavlov ...
6 years, 2 months ago (2014-10-13 14:38:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650123002/110001
6 years, 2 months ago (2014-10-13 14:39:48 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 16:22:38 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:110001) as 183612

Powered by Google App Engine
This is Rietveld 408576698