Flatten down to a single toolbar per window, significantly simplifying the ta...

Flatten down to a single toolbar per window, significantly simplifying the tab strip as it now no longer needs to forward messages for everything. Created a toolbar controller to encapsulate much of the toolbar logic that was in the tab contents controller. Better parameterized the tab strip controller so that it could switch any view, not just the main window's content view, when switching tabs.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13441

[pink (ping after 24hrs), 2009-04-09 15:29:07]

This is stage one. It still leaves the bookmark bar per tab and has some issues
with dragging tabs to new windows (but that's still in flux anyway). I'll
continue working on those issues, just wanted to checkpoint this work.

[TVL, 2009-04-09 15:53:00]

lgtm

http://codereview.chromium.org/65011/diff/1/9
File chrome/browser/cocoa/tab_window_controller.mm (right):

http://codereview.chromium.org/65011/diff/1/9#newcode21
Line 21: NSRect tabFrame = [tabContentArea_ frame];
you could DCheck the class requirements on tabContentArea_ you mentioned in the
header for safety.

http://codereview.chromium.org/65011/diff/1/9#newcode56
Line 56: [overlayWindow_ contentView] : [cachedContentView_ superview];
move this outside the loop, it doesn't need loop state to pick.

http://codereview.chromium.org/65011/diff/1/11
File chrome/browser/cocoa/toolbar_controller.mm (right):

http://codereview.chromium.org/65011/diff/1/11#newcode24
Line 24: if ((self = [super initWithNibName:@"Toolbar" bundle:nil])) {
dcheck model and commands like the other classes do?

http://codereview.chromium.org/65011/diff/1/11#newcode81
Line 81: break;
fix the indents here

http://codereview.chromium.org/65011/diff/1/11#newcode94
Line 94: [starButton_ setEnabled:commands->IsCommandEnabled(IDC_STAR) ? YES :
NO];
todo(pinkerton) home button

[pink (ping after 24hrs), 2009-04-09 16:00:48]

http://codereview.chromium.org/65011/diff/1/9
File chrome/browser/cocoa/tab_window_controller.mm (right):

http://codereview.chromium.org/65011/diff/1/9#newcode21
Line 21: NSRect tabFrame = [tabContentArea_ frame];
On 2009/04/09 15:53:00, TVL wrote:
> you could DCheck the class requirements on tabContentArea_ you mentioned in
the
> header for safety.

do what, though? check that it's not an NSBox? that seems odd.

http://codereview.chromium.org/65011/diff/1/9#newcode56
Line 56: [overlayWindow_ contentView] : [cachedContentView_ superview];
On 2009/04/09 15:53:00, TVL wrote:
> move this outside the loop, it doesn't need loop state to pick.

duh. changed this around at the last minute and missed that.

http://codereview.chromium.org/65011/diff/1/11
File chrome/browser/cocoa/toolbar_controller.mm (right):

http://codereview.chromium.org/65011/diff/1/11#newcode24
Line 24: if ((self = [super initWithNibName:@"Toolbar" bundle:nil])) {
On 2009/04/09 15:53:00, TVL wrote:
> dcheck model and commands like the other classes do?

Done.

http://codereview.chromium.org/65011/diff/1/11#newcode81
Line 81: break;
On 2009/04/09 15:53:00, TVL wrote:
> fix the indents here

Done.

http://codereview.chromium.org/65011/diff/1/11#newcode94
Line 94: [starButton_ setEnabled:commands->IsCommandEnabled(IDC_STAR) ? YES :
NO];
On 2009/04/09 15:53:00, TVL wrote:
> todo(pinkerton) home button

Done.