Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 650103003: Turn off Blink Scheduler by default. (Closed)

Created:
6 years, 2 months ago by rmcilroy
Modified:
6 years, 2 months ago
Reviewers:
Mike West, eseidel
CC:
blink-reviews, mkwst+moarreviews_chromium.org, Sami
Project:
blink
Visibility:
Public.

Description

Turn off Blink Scheduler by default. BUG=422841 TBR=eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183876

Patch Set 1 #

Patch Set 2 : Enable scheduler for tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scheduler/SchedulerTest.cpp View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
rmcilroy
eseidel: could you take a look please? Thanks.
6 years, 2 months ago (2014-10-16 22:09:51 UTC) #2
rmcilroy
On 2014/10/16 22:09:51, rmcilroy wrote: > eseidel: could you take a look please? Thanks. TBRing ...
6 years, 2 months ago (2014-10-16 23:14:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650103003/1
6 years, 2 months ago (2014-10-16 23:16:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/27388)
6 years, 2 months ago (2014-10-16 23:32:05 UTC) #7
Mike West
LGTM.
6 years, 2 months ago (2014-10-17 08:12:06 UTC) #9
Mike West
Looks like you should set status=test, or disable the Scheduler tests that are failing.
6 years, 2 months ago (2014-10-17 08:12:36 UTC) #10
rmcilroy
On 2014/10/17 08:12:36, Mike West wrote: > Looks like you should set status=test, or disable ...
6 years, 2 months ago (2014-10-17 09:26:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650103003/20001
6 years, 2 months ago (2014-10-17 09:27:15 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 10:35:41 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183876

Powered by Google App Engine
This is Rietveld 408576698