Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 650083003: [turbofan] Use register for instruction operands when SameAsFirst is specified. (Closed)

Created:
6 years, 2 months ago by Jarin
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Use register for instruction operands when SameAsFirst is specified. As the register allocator cannot reuse spill slots, SameAsFirst constraint means that we would have to do an expensive move to a differen spill slot if we choose to spill. Forcing the operand to a register is cheaper. In zlib, we get >10% speed-up for ia32, >25% for x64. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 9 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jarin
Could you take a look, please?
6 years, 2 months ago (2014-10-13 15:17:39 UTC) #2
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-13 18:27:35 UTC) #3
Jarin
6 years, 2 months ago (2014-10-14 08:34:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24580 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698